Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: upgrade packetSniffer to latest ABCIListener API #1398

Merged

Conversation

tbruyelle
Copy link
Contributor

@tbruyelle tbruyelle commented Nov 8, 2023

Relates: #1349

Also remove unused func ABCIToSDKEvents.

Please go the the Preview tab and select the appropriate sub-template:

  • Production code - for types fix, feat, and refactor.
  • Docs - for documentation changes.
  • Others - for changes that do not affect production code.

@tbruyelle tbruyelle requested a review from a team as a code owner November 8, 2023 14:55
Relates: cosmos#1349

Also remove unused func ABCIToSDKEvents.
@tbruyelle tbruyelle force-pushed the tbruyelle/v50-upgrade-ibctesting branch from 4abafd7 to 335cd90 Compare November 8, 2023 14:57
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Nov 8, 2023
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes!

I can confirm this fixes packet sniffing.

Approve!

@MSalopek MSalopek merged commit 657c063 into cosmos:feat/v50-upgrade Nov 8, 2023
3 of 10 checks passed
@MSalopek MSalopek linked an issue Nov 8, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade integration testing framework for v50
2 participants