Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test and fix key assignment branch #1431

Merged
merged 7 commits into from
Nov 15, 2023
Merged

fix: test and fix key assignment branch #1431

merged 7 commits into from
Nov 15, 2023

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Nov 15, 2023

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler C:Docs Assigned automatically by the PR labeler C:ADR Assigned automatically by the PR labeler labels Nov 15, 2023
@sainoe sainoe changed the base branch from feat/refactor-key-assignment to main November 15, 2023 09:46
@sainoe sainoe changed the base branch from main to feat/refactor-key-assignment November 15, 2023 09:47
sainoe
sainoe commented Nov 15, 2023
View reviewed changes
proto/interchain_security/ccv/provider/v1/query.proto
@@ -73,6 +73,15 @@ service Query {
option (google.api.http).get =
"/interchain_security/ccv/provider/registered_consumer_reward_denoms";
}

// QueryProposedConsumerChainIDs returns the chain IDs of the proposed consumer chain addition proposals
Copy link
Contributor Author

@sainoe sainoe Nov 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDNK why git's seeing this change. The protos aren't changed.

https://github.com/cosmos/interchain-security/blob/feat/refactor-key-assignment/proto/interchain_security/ccv/provider/v1/query.proto#L79-L86

@github-actions github-actions bot removed C:x/consumer Assigned automatically by the PR labeler C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler C:Docs Assigned automatically by the PR labeler C:ADR Assigned automatically by the PR labeler labels Nov 15, 2023
@sainoe sainoe merged commit e1cb6b3 into feat/refactor-key-assignment Nov 15, 2023
3 checks passed
@sainoe sainoe deleted the sainoe/refactor-key-assignment branch November 15, 2023 10:01
mpoke
mpoke reviewed Nov 15, 2023
View reviewed changes
.changelog/unreleased/consensus-breaking/provider/1339-check-key-assignment-in-use.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sainoe could you please change this to state-breaking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke mpoke left review comments

Assignees
No one assigned
Labels
C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sainoe @mpoke