Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps!: use cosmos-sdk v47-lsm #1617

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Feb 1, 2024

Description

Due to changes on https://github.com/cosmos/cosmos-sdk/commits/feature/v0.47.x-ics-lsm/ we need to use cosmos-sdk v47 with LSM changes on ICS.

Without these changes ICS does not build or install:

$: make install
export GOFLAGS='-buildmode=pie'
export CGO_CPPFLAGS="-D_FORTIFY_SOURCE=2"
export CGO_LDFLAGS="-Wl,-z,relro,-z,now -fstack-protector"
go install -ldflags "<injected_flags>" ./cmd/interchain-security-pd
# github.com/cosmos/interchain-security/v3/x/ccv/provider/keeper
x/ccv/provider/keeper/hooks.go:22:32: cannot use Hooks{} (value of type Hooks) as "github.com/cosmos/cosmos-sdk/x/gov/types".GovHooks value in variable declaration: Hooks does not implement "github.com/cosmos/cosmos-sdk/x/gov/types".GovHooks (wrong type for method AfterProposalDeposit)
		have AfterProposalDeposit("github.com/cosmos/cosmos-sdk/types".Context, uint64, "github.com/cosmos/cosmos-sdk/types".AccAddress)
		want AfterProposalDeposit("github.com/cosmos/cosmos-sdk/types".Context, uint64, "github.com/cosmos/cosmos-sdk/types".AccAddress) error
make: *** [install] Error 1

Future PRs may add a changelog and use a tagged version.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@MSalopek MSalopek added type: tech-debt Slows down development in the long run dependencies S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) labels Feb 1, 2024
@MSalopek MSalopek self-assigned this Feb 1, 2024
@MSalopek MSalopek requested a review from a team as a code owner February 1, 2024 16:23
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sainoe sainoe self-requested a review February 1, 2024 16:36
@MSalopek MSalopek merged commit bde0df5 into release/v3.3.x-lsm Feb 1, 2024
11 of 12 checks passed
@MSalopek MSalopek deleted the masa/use-v47-lsm-branch branch February 1, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) type: tech-debt Slows down development in the long run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants