Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix e2e testcase selection #1706

Merged
merged 2 commits into from
Mar 18, 2024
Merged

test: fix e2e testcase selection #1706

merged 2 commits into from
Mar 18, 2024

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Mar 14, 2024

Description

In e2e tests the selection of a test case with specific test config did not work as specified ("-tc testcase::testconfig").
Also when running multiple test case the TestRunner where referencing a TestTarget, instead of having it's own instance, which caused side effects.
Fix will provide each test runner it's own target instance.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Mar 14, 2024
@bermuell bermuell self-assigned this Mar 14, 2024
@bermuell bermuell marked this pull request as ready for review March 14, 2024 14:47
@bermuell bermuell requested a review from a team as a code owner March 14, 2024 14:47
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

Could you please elaborate in the PR description what was done or here the issue originated from.

@sainoe sainoe self-requested a review March 15, 2024 07:24
@bermuell bermuell added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit cd0d075 Mar 18, 2024
25 checks passed
@bermuell bermuell deleted the bernd/fix-e2e-testselection branch March 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants