Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add oldest_unconfirmed_vsc query (backport #1740) #1744

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 2, 2024

Description

Closes: #1263


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

This is an automatic backport of pull request #1740 done by [Mergify](https://mergify.com).

* fix logging in ibc_module.go

* update proto files

* add query to keeper

* add CLI query

* add changelog entry

* change name to oldest_unconfirmed_vsc

* update changelog entry

* fix error messages

* fix UT

* adding comment for clarity

* QueryOldestUnconfirmVsc -> QueryOldestUnconfirmedVsc

* improve UT

(cherry picked from commit 60c4fd0)

# Conflicts:
#	.changelog/v3.2.0/features/consumer/1164-provider-info-query.md
#	.changelog/v4.1.0/features/provider/1740-oldest-unconfirm-vsc-query.md
@mergify mergify bot requested a review from a team as a code owner April 2, 2024 13:20
@mergify mergify bot added the conflicts label Apr 2, 2024
Copy link
Contributor Author

mergify bot commented Apr 2, 2024

Cherry-pick of 60c4fd0 has failed:

On branch mergify/bp/release/v4.1.x/pr-1740
Your branch is up to date with 'origin/release/v4.1.x'.

You are currently cherry-picking commit 60c4fd0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   proto/interchain_security/ccv/provider/v1/query.proto
	modified:   x/ccv/consumer/ibc_module.go
	modified:   x/ccv/provider/client/cli/query.go
	modified:   x/ccv/provider/ibc_module.go
	modified:   x/ccv/provider/keeper/grpc_query.go
	modified:   x/ccv/provider/keeper/grpc_query_test.go
	modified:   x/ccv/provider/types/errors.go
	modified:   x/ccv/provider/types/provider.pb.go
	modified:   x/ccv/provider/types/query.pb.go
	modified:   x/ccv/provider/types/query.pb.gw.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .changelog/v3.2.0/features/consumer/1164-provider-info-query.md
	added by them:   .changelog/v4.1.0/features/provider/1740-oldest-unconfirm-vsc-query.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned mpoke Apr 2, 2024
@github-actions github-actions bot added C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Apr 2, 2024
@mpoke mpoke merged commit d7cb8b2 into release/v4.1.x Apr 2, 2024
17 checks passed
@mpoke mpoke deleted the mergify/bp/release/v4.1.x/pr-1740 branch April 2, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant