feat!: remove VSCMaturedPackets (provider changes) #2098
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Outside diff range, codebase verification and nitpick comments (9)
x/ccv/provider/ibc_module.go (1)
200-201: IgnoringVscMaturedPacketpackets has significant dependencies.The
VscMaturedPackettype is used extensively throughout the codebase, including in tests, protobuf definitions, and various modules. Ignoring these packets may have unintended consequences. Please review the impact of this change thoroughly.
- Files and lines of interest:
x/ccv/types/wire_test.gox/ccv/types/wire.pb.gox/ccv/provider/ibc_module.gox/ccv/provider/ibc_module_test.gox/ccv/types/wire.gox/ccv/consumer/keeper/relay.gox/ccv/consumer/keeper/relay_test.gox/ccv/consumer/types/genesis.gox/ccv/consumer/types/genesis_test.gox/ccv/consumer/migrations/v2/migration_test.gox/ccv/consumer/keeper/keeper_test.gox/ccv/consumer/keeper/genesis_test.goAnalysis chain
Modification to ignore
VscMaturedPacketpackets approved, but verify impact.The change simplifies the control flow by ignoring
VscMaturedPacketpackets. Ensure that this change does not negatively impact the broader application.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of ignoring `VscMaturedPacket` packets on the broader application. # Test: Search for the usage of `VscMaturedPacket`. Expect: No critical dependencies on this packet type. rg --type go -A 5 $'VscMaturedPacket'Length of output: 24683
x/ccv/provider/keeper/key_assignment_test.go (8)
192-193: Add context to variable names.The variables
consumerAddr1andconsumerAddr2could be more descriptive to indicate their purpose or context.- consumerAddr1 := types.NewConsumerConsAddress([]byte("consumerAddr1")) - consumerAddr2 := types.NewConsumerConsAddress([]byte("consumerAddr2")) + firstConsumerAddr := types.NewConsumerConsAddress([]byte("firstConsumerAddr")) + secondConsumerAddr := types.NewConsumerConsAddress([]byte("secondConsumerAddr"))
198-199: Consider adding comments for timestamps.Adding comments to explain the purpose of
ts1andts2will improve code readability.- ts1 := ctx.BlockTime() - ts2 := ts1.Add(time.Hour) + // Timestamp for the first pruning operation + ts1 := ctx.BlockTime() + // Timestamp for the second pruning operation + ts2 := ts1.Add(time.Hour)
204-205: Ensure consistent error messages.The error message "addresses to prune is empty" is slightly different from the one used later. Consider making them consistent.
- require.Empty(t, addrsToPrune) + require.Empty(t, addrsToPrune, "addresses to prune is not empty")
218-220: Ensure consistent error messages.The error message "addresses to prune was returned" is slightly different from the one used earlier. Consider making them consistent.
- require.Empty(t, addrsToPrune, "addresses to prune was returned") + require.Empty(t, addrsToPrune, "addresses to prune is not empty")
228-235: Ensure consistent error messages.The error message "addresses to prune was returned" is slightly different from the one used earlier. Consider making them consistent.
- require.NotEmpty(t, addrsToPrune, "addresses to prune was returned") + require.NotEmpty(t, addrsToPrune, "addresses to prune is not empty")
248-258: Add context to variable names.The variable
testAssignmentscould be more descriptive to indicate its purpose or context.- testAssignments := []types.ConsumerAddrsToPruneV2{} + consumerAddrsToPruneAssignments := []types.ConsumerAddrsToPruneV2{}
277-285: Consider adding comments for sorting logic.Adding comments to explain the sorting logic will improve code readability.
- // sorting by ConsumerAddrsToPrune.PruneTs + // Sorting by PruneTs to ensure addresses are pruned in the correct order
291-291: Add context to variable names.The variable
consumerAddrcould be more descriptive to indicate its purpose or context.- consumerAddr := types.NewConsumerConsAddress(addr) + consumerConsAddr := types.NewConsumerConsAddress(addr)
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range, codebase verification and nitpick comments (4)
x/ccv/provider/keeper/params.go (1)
Line range hint
26-30:
Ensure proper error handling inGetParamsThe
GetParamsfunction panics if there is an error unmarshalling the module parameters. Consider handling the error more gracefully.- if err != nil { - panic(fmt.Sprintf("error unmarshalling module parameters: %v:", err)) - } + if err != nil { + return types.Params{}, fmt.Errorf("error unmarshalling module parameters: %v", err) + }x/ccv/provider/types/genesis.go (1)
24-24: Ensure complete migration toConsumerAddrsToPruneV2.The old data structure
ConsumerAddrsToPruneis still being referenced in the following file:
testutil/keeper/unit_test_helpers.go: require.Empty(t, providerKeeper.GetAllConsumerAddrsToPrune(ctx, expectedChainID))Please update this reference to
ConsumerAddrsToPruneV2to maintain consistency.Analysis chain
Verify the usage of
ConsumerAddrsToPruneV2throughout the codebase.Ensure that all references to
ConsumerAddrsToPrunehave been updated toConsumerAddrsToPruneV2to maintain consistency.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `ConsumerAddrsToPrune` are updated to `ConsumerAddrsToPruneV2`. # Test: Search for the old data structure. Expect: No occurrences of `ConsumerAddrsToPrune`. rg --type go 'ConsumerAddrsToPrune'Length of output: 14724
docs/docs/adrs/adr-018-remove-vscmatured.md (1)
171-172: Avoid repetitive sentence beginnings.The sentences starting with 'Remove' can be rephrased for better readability.
- Remove unnecessary complexity, from both ICS and Cosmos SDK. - Remove one IBC packet and, thus, reduce relaying cost. - Remove unbonding pausing logic that could affect the UX. + This change will eliminate unnecessary complexity from both ICS and Cosmos SDK. + It will also reduce relaying cost by removing one IBC packet. + Additionally, it will remove unbonding pausing logic that could affect the UX.Tools
LanguageTool
[style] ~171-~171: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...exity, from both ICS and Cosmos SDK. - Remove one IBC packet and, thus, reduce relayi...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~172-~172: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ket and, thus, reduce relaying cost. - Remove unbonding pausing logic that could affe...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Markdownlint
171-171: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
172-172: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
171-171: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
x/ccv/provider/keeper/key_assignment_test.go (1)
192-193: Add context to consumer addresses.Consider adding comments to explain the purpose of
consumerAddr1andconsumerAddr2for better readability.
There was a problem hiding this comment.
Actionable comments posted: 4
Outside diff range, codebase verification and nitpick comments (19)
x/ccv/provider/types/events.go (1)
Ensure complete removal of
AttributeInitializationTimeout.The constant
AttributeInitializationTimeoutis still present in the codebase.
- File:
x/ccv/types/events.go- Line:
AttributeInitializationTimeout = "initialization_timeout"Please remove all references to
AttributeInitializationTimeoutto avoid potential issues.Analysis chain
Line range hint
1-20:
Ensure removal ofAttributeInitializationTimeoutis complete.The
AttributeInitializationTimeoutconstant has been removed. Verify that all references toAttributeInitializationTimeouthave been removed from the codebase to avoid any potential issues.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `AttributeInitializationTimeout` have been removed from the codebase. # Test: Search for any remaining references to `AttributeInitializationTimeout`. Expect: No matches. rg --type go 'AttributeInitializationTimeout'Length of output: 129
tests/integration/unbonding.go (1)
7-9: Update function documentation to reflect new purpose.The function
TestUndelegationNormalOperationhas been renamed toTestUndelegationCompletion. Ensure the documentation accurately reflects the new purpose of the function.-// TestUndelegationCompletion tests that undelegations complete after -// the unbonding period elapses on the provider, regardless of the consumer's state +// TestUndelegationCompletion tests that undelegations complete after +// the unbonding period elapses on the provider, regardless of the consumer's state.x/ccv/provider/module_test.go (1)
Ensure all function calls to
NewGenesisStatematch the new signature.The simplification by removing
nilarguments from theNewGenesisStatefunction call is approved.However, ensure that all function calls to
NewGenesisStatematch the new signature. The search results indicate that some function calls still includenilarguments, which might not align with the new function signature.
- Files with old
NewGenesisStatesignature:
x/ccv/provider/module_test.gox/ccv/provider/keeper/genesis_test.gox/ccv/provider/types/genesis_test.goPlease update these instances to match the new function signature.
Analysis chain
Line range hint
84-84:
LGTM! But verify the function usage in the codebase.The simplification by removing
nilarguments from theNewGenesisStatefunction call is approved.However, ensure that all function calls to
NewGenesisStatematch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `NewGenesisState` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'NewGenesisState'Length of output: 11844
docs/docs/adrs/adr-018-remove-vscmatured.md (5)
26-26: Remove comma before 'because'.If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
- Partially synchronous means that the lag between the Hub’s view of stake and the consumer’s view of stake is bounded, because consumers that exceed this lag are forcibly removed from the protocol. + Partially synchronous means that the lag between the Hub’s view of stake and the consumer’s view of stake is bounded because consumers that exceed this lag are forcibly removed from the protocol.Tools
LanguageTool
[formatting] ~26-~26: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ... the consumer’s view of stake is bounded, because consumers that exceed this lag are forc...(COMMA_BEFORE_BECAUSE)
40-40: Add missing comma.A comma is needed to separate the clauses for better readability.
- First, `VSCMaturedPackets` provide a "false" sense of correctness as the attack discribed above is still possible. + First, `VSCMaturedPackets` provide a "false" sense of correctness, as the attack described above is still possible.Tools
LanguageTool
[uncategorized] ~40-~40: Possible missing comma found.
Context: ...uredPackets` provide a "false" sense of correctness as the attack discribed above is still ...(AI_HYDRA_LEO_MISSING_COMMA)
41-41: Correct verb agreement.The verb does not agree with the subject. Use a different form.
- Second, `VSCMaturedPackets` add considerable complexity to the ICS protocol. + Second, `VSCMaturedPackets` adds considerable complexity to the ICS protocol.Tools
LanguageTool
[uncategorized] ~41-~41: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...l possible. Second,VSCMaturedPacketsadd considerable complexity to the ICS prot...(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
158-158: Use 'clean up' instead of 'cleanup'.Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
- In addition, to cleanup the code, the `QueueVSCMaturedPackets` must be removed. + In addition, to clean up the code, the `QueueVSCMaturedPackets` must be removed.Tools
LanguageTool
[misspelling] ~158-~158: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: ...lapsed maturity times. In addition, to cleanup the code, theQueueVSCMaturedPackets...(CLEAN_UP)
Markdownlint
158-158: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
171-172: Avoid repetitive sentence beginnings.Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
- Remove unnecessary complexity, from both ICS and Cosmos SDK. - Remove one IBC packet and, thus, reduce relaying cost. - Remove unbonding pausing logic that could affect the UX. + This will eliminate unnecessary complexity from both ICS and Cosmos SDK. + Additionally, it will remove one IBC packet, thus reducing relaying cost. + Finally, it will eliminate unbonding pausing logic that could affect the UX.Tools
LanguageTool
[style] ~171-~171: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...exity, from both ICS and Cosmos SDK. - Remove one IBC packet and, thus, reduce relayi...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~172-~172: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ket and, thus, reduce relaying cost. - Remove unbonding pausing logic that could affe...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Markdownlint
171-171: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
172-172: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
171-171: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
x/ccv/provider/keeper/key_assignment_test.go (11)
192-193: Declare consumerAddr1 and consumerAddr2 together.To improve readability, declare
consumerAddr1andconsumerAddr2together.- consumerAddr1 := types.NewConsumerConsAddress([]byte("consumerAddr1")) - consumerAddr2 := types.NewConsumerConsAddress([]byte("consumerAddr2")) + consumerAddr1, consumerAddr2 := types.NewConsumerConsAddress([]byte("consumerAddr1")), types.NewConsumerConsAddress([]byte("consumerAddr2"))
198-199: Add a comment explaining the timestamps.Adding a comment to explain the purpose of
ts1andts2will enhance code readability.+ // ts1 and ts2 represent different pruning timestamps. ts1 := ctx.BlockTime() ts2 := ts1.Add(time.Hour)
204-205: Add a comment explaining the append operation.Adding a comment to explain the purpose of appending
consumerAddr1tots1will enhance code readability.+ // Append consumerAddr1 to prune at ts1. keeper.AppendConsumerAddrsToPrune(ctx, chainID, ts1, consumerAddr1)
211-211: Add a comment explaining the append operation.Adding a comment to explain the purpose of appending
consumerAddr2tots2will enhance code readability.+ // Append consumerAddr2 to prune at ts2. keeper.AppendConsumerAddrsToPrune(ctx, chainID, ts2, consumerAddr2)
218-218: Add a comment explaining the delete operation.Adding a comment to explain the purpose of deleting addresses to prune at
ts1will enhance code readability.+ // Delete consumer addresses to prune at ts1. keeper.DeleteConsumerAddrsToPrune(ctx, chainID, ts1)
226-227: Add a comment explaining the append operation.Adding a comment to explain the purpose of appending
consumerAddr1tots1again will enhance code readability.+ // Re-append consumerAddr1 to prune at ts1. keeper.AppendConsumerAddrsToPrune(ctx, chainID, ts1, consumerAddr1)
248-248: Add a comment explaining the test assignments.Adding a comment to explain the purpose of the
testAssignmentsslice will enhance code readability.+ // testAssignments holds ConsumerAddrsToPruneV2 instances for testing. testAssignments := []types.ConsumerAddrsToPruneV2{}
256-258: Add a comment explaining the ConsumerAddrsToPruneV2 fields.Adding a comment to explain the fields of
ConsumerAddrsToPruneV2will enhance code readability.types.ConsumerAddrsToPruneV2{ ChainId: chainIDs[rng.Intn(len(chainIDs))], PruneTs: time.Now().UTC(), ConsumerAddrs: &consumerAddresses, },
277-277: Add a comment explaining the expected order.Adding a comment to explain the purpose of
expectedGetAllOrderwill enhance code readability.+ // expectedGetAllOrder holds the expected order of ConsumerAddrsToPruneV2 instances. expectedGetAllOrder := []types.ConsumerAddrsToPruneV2{}
283-285: Add a comment explaining the sorting mechanism.Adding a comment to explain the sorting mechanism by
PruneTswill enhance code readability.+ // Sort expectedGetAllOrder by PruneTs. sort.Slice(expectedGetAllOrder, func(i, j int) bool { return expectedGetAllOrder[i].PruneTs.Before(expectedGetAllOrder[j].PruneTs) })
291-291: Add a comment explaining the append operation.Adding a comment to explain the purpose of appending consumer addresses to prune will enhance code readability.
+ // Append consumer addresses to prune for each assignment. pk.AppendConsumerAddrsToPrune(ctx, assignment.ChainId, assignment.PruneTs, consumerAddr)
|
Hey, I think I mentioned it on the old PR, but just to not have it get lost, docs need to be adjusted: (Probably sufficient to just delete the removed parameters from the docs here) |
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (4)
.changelog/unreleased/state-breaking/provider/2098-vscmatured-removal.md (1)
1-2: Ensure the changelog entry is clear and complete.The changelog entry is clear but could benefit from a brief explanation of the impact of removing
VSCMaturedPacketsto provide more context.- Remove `VSCMaturedPackets` from the provider module. + Remove `VSCMaturedPackets` from the provider module, which affects unbonding operations and timeout management..changelog/unreleased/api-breaking/provider/2098-vscmatured-removal.md (1)
1-7: Ensure the changelog entry is clear and complete.The changelog entry is clear but could benefit from a brief explanation of the impact of the removed query and deprecated parameters to provide more context.
- The removal of `VSCMaturedPackets` entail several API breaking changes. + The removal of `VSCMaturedPackets` entails several API breaking changes, affecting how unbonding operations and timeout management are handled..changelog/unreleased/features/provider/2098-vscmatured-removal.md (1)
1-8: Ensure the changelog entry is clear and complete.The changelog entry is clear but could benefit from a brief explanation of the impact of the changes listed to provide more context.
- Remove `VSCMaturedPackets` from the provider module, which entails the following + Remove `VSCMaturedPackets` from the provider module, which entails the following changes to unbonding operations and timeout management:x/ccv/types/events.go (1)
EventTypeVSCMaturedis still present in the codebase.The constant
EventTypeVSCMaturedis defined and used in the following locations:
x/ccv/consumer/types/events.gox/ccv/consumer/keeper/relay.goPlease remove
EventTypeVSCMaturedfrom these files if it is no longer needed.
File:
x/ccv/consumer/types/events.go
- Line:
EventTypeVSCMatured = "vsc_matured"File:
x/ccv/consumer/keeper/relay.go
- Line:
types.EventTypeVSCMaturedAnalysis chain
Line range hint
1-33:
Verify the removal ofEventTypeVSCMatured.Ensure that all references to
EventTypeVSCMaturedhave been removed or updated in the codebase to prevent errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that `EventTypeVSCMatured` is no longer referenced in the codebase. # Test: Search for the constant usage. Expect: No occurrences of `EventTypeVSCMatured`. rg --type go 'EventTypeVSCMatured'Length of output: 178
Script:
#!/bin/bash # Description: Gather context around the occurrences of `EventTypeVSCMatured` in the codebase. # Search for the lines around the definition and usage of `EventTypeVSCMatured`. rg --type go -A 5 -B 5 'EventTypeVSCMatured' x/ccv/consumer/types/events.go x/ccv/consumer/keeper/relay.goLength of output: 1804
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
x/ccv/provider/keeper/key_assignment_test.go (1)
192-237: Ensure test coverage for edge cases.The current test for
ConsumeConsumerAddrsToPruneinkey_assignment_test.godoes not cover scenarios where not all consumer addresses are consumed. Please add tests to ensure that the function respects the timestamp and correctly handles partial consumption of addresses.
- Add a unit test where not all consumer addresses are consumed by
ConsumeConsumerAddrsToPrune.- Verify that the test respects the timestamp correctly.
Analysis chain
Verify test coverage for edge cases.
Ensure there is a unit test where not all consumer addresses are consumed by
ConsumeConsumerAddrsToPrune. Verify that the test respects the timestamp correctly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify test coverage for edge cases in `TestConsumerAddrsToPruneCRUD`. # Test: Search for the function usage. Expect: Unit tests covering edge cases. rg --type go -A 5 $'ConsumeConsumerAddrsToPrune'Length of output: 3218
Script:
#!/bin/bash # Description: Search for additional tests covering edge cases for `ConsumeConsumerAddrsToPrune`. # Test: Search for test functions in the repository that use `ConsumeConsumerAddrsToPrune`. rg --type go -A 5 -g '*_test.go' $'ConsumeConsumerAddrsToPrune'Length of output: 767
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (15)
x/ccv/provider/keeper/relay.go (1)
169-170: Ensure consistency in logging statements.The logging statements should be consistent across the codebase for better traceability.
- k.Logger(ctx).Info("VSCPacket enqueued:", + k.Logger(ctx).Info("VSC packet enqueued:",x/ccv/provider/keeper/relay_test.go (14)
Line range hint
14-50:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
52-97:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
99-159:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
161-196:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
210-264:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
266-370:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
372-402:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
404-415:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
417-434:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
436-446:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
448-469:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
471-520:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
522-574:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Line range hint
576-619:
Consider adding more edge cases.The test cases cover basic scenarios. Consider adding edge cases, such as invalid data or boundary conditions, to ensure robustness.
Description
Closes: NA
See the ADR for more details.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if the change is state-machine breakingCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!the type prefix if the change is state-machine breakingSummary by CodeRabbit
New Features
VSCMaturedPackets.Bug Fixes
Refactor
Keeperstruct's methods and related operations for better maintainability.Documentation
Tests