Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for v5.1.1 release #2100

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Jul 26, 2024

Description

Update changelog and release docs for ICS v5.1.1.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct docs: prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR only changes documentation
  • Reviewed content for consistency
  • Reviewed content for spelling and grammar
  • Tested instructions (if applicable)
  • Checked that the documentation website can be built and deployed successfully (run make build-docs)

Summary by CodeRabbit

  • New Features

    • Introduced a new changelog entry for version 5.1.1, enhancing documentation and transparency.
  • Bug Fixes

    • Corrected message definitions in the provider module, potentially impacting existing implementations.
  • Documentation

    • Updated release notes to reflect version 5.1.1, restructuring highlights for clarity and conciseness.
    • Revised upgrading documentation to clarify upgrade paths for version 5.1.1.

@sainoe sainoe requested a review from a team as a code owner July 26, 2024 07:25
Copy link
Contributor

coderabbitai bot commented Jul 26, 2024

Walkthrough

Walkthrough

The update to version 5.1.1 emphasizes critical improvements, particularly in rectifying message definitions within the provider module's protocol files. This release is marked as both API and state breaking, prompting users to verify their implementations for compatibility. Additionally, the changelog and release notes have been enhanced to provide clearer, more concise insights into the changes and their potential impacts on users.

Changes

Files Change Summary
.changelog/v5.1.1/summary.md, CHANGELOG.md Added entry for version 5.1.1 and documented corrections in protocol files affecting the provider module; API and state breaking changes noted. Reference to pull request #2095 added.
RELEASE_NOTES.md Updated metadata, restructured highlights, and emphasized bug fixes related to provider module message definitions; simplified content.
UPGRADING.md, docs/docs/upgrading/migrate_v4_v5.md Updated version references and upgrade compatibility notes for v5.1.1.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    participant Provider Module
    participant Protocol Files

    User->>Application: Request to interact with Provider Module
    Application->>Provider Module: Call with old message definition
    Provider Module->>Protocol Files: Validate message
    alt Validation fails
        Provider Module-->>Application: Return error
    else Validation succeeds
        Provider Module->>Application: Process request
        Application-->>User: Return response
    end
Loading

Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 864f50b and 94d0445.

Files selected for processing (2)
  • UPGRADING.md (1 hunks)
  • docs/docs/upgrading/migrate_v4_v5.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • docs/docs/upgrading/migrate_v4_v5.md
Additional context used
Path-based instructions (1)
UPGRADING.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness. Please DO NOT report any missing or superfluous newlines, in particular at the end or beginning of files. Only report issues that you have a high degree of confidence in."

Markdownlint
UPGRADING.md

17-17: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

Additional comments not posted (4)
UPGRADING.md (4)

3-3: LGTM! Version reference updated correctly.

The version reference in the heading has been correctly updated to v5.1.x.


7-7: LGTM! Provider note updated correctly.

The note for providers has been correctly updated to reflect the new version v5.1.1.


9-11: LGTM! Provider upgrade path updated correctly.

The provider upgrade path has been correctly updated to reflect the new version v5.1.1.


17-17: LGTM! Consumer upgrade path updated correctly.

The consumer upgrade path has been correctly updated to reflect the new version v5.1.1.

Tools
Markdownlint

17-17: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
RELEASE_NOTES.md (1)

1-4: Correct the comparison link in the release notes.

The changelog link is correct, but the comparison link is invalid (404 error). Please update the comparison link to accurately compare v5.1.0 to v5.1.1.

  • Current link: v5.1.0...v5.1.1
  • Suggested correction: Verify the correct URL format for comparing versions on GitHub and update accordingly.
Analysis chain

Verify the changelog link.

Ensure that the changelog link points to the correct version (v5.1.0) and the comparison link accurately compares v5.1.0 to v5.1.1.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness of the changelog and comparison links.

# Test: Check if the changelog link is correct. Expect: Link to v5.1.0 changelog.
curl -s -o /dev/null -w "%{http_code}" https://github.com/cosmos/interchain-security/blob/v5.1.0/CHANGELOG.md

# Test: Check if the comparison link is correct. Expect: Link comparing v5.1.0 to v5.1.1.
curl -s -o /dev/null -w "%{http_code}" https://github.com/cosmos/interchain-security/compare/v5.1.0...v5.1.1

Length of output: 229

Tools
Markdownlint

3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)

@sainoe sainoe changed the title docs: update docs for v5..1.1 release docs: update docs for v5.1.1 release Jul 26, 2024
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one link needs to be changed afaict

RELEASE_NOTES.md Outdated Show resolved Hide resolved
@p-offtermatt
Copy link
Contributor

Should this also be adjusted to say v5.1.1?

The provider should be updated to `v5.1.0`.

Co-authored-by: Philip Offtermatt <[email protected]>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
RELEASE_NOTES.md (1)

3-3: Add a blank line before the heading.

Headings should be surrounded by blank lines to improve readability.

-
## 📝 Changelog
Tools
Markdownlint

3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)

@github-actions github-actions bot added the C:Docs Assigned automatically by the PR labeler label Jul 26, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


Upgrade code will be executed automatically during the upgrade procedure.

### Consumer

Upgrading the consumer from `v5.0.0` to `v5.1.0` will not require state migration.
Upgrading the consumer from `v5.0.0` to `v5.1.1` will not require state migration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing space.

There is a trailing space at the end of the line. Remove it to adhere to markdownlint rules.

- Upgrading the consumer from `v5.0.0` to `v5.1.1` will not require state migration. 
+ Upgrading the consumer from `v5.0.0` to `v5.1.1` will not require state migration.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Upgrading the consumer from `v5.0.0` to `v5.1.1` will not require state migration.
Upgrading the consumer from `v5.0.0` to `v5.1.1` will not require state migration.
Tools
Markdownlint

17-17: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

@sainoe sainoe merged commit 2be3936 into release/v5.1.x Jul 29, 2024
12 of 13 checks passed
@sainoe sainoe deleted the sainoe/v511-release-docs branch July 29, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Docs Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants