Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ADR for Customizable Slashing and Jailing #2146
docs: ADR for Customizable Slashing and Jailing #2146
Changes from all commits
897a300
bca9eb5
eb5f1e9
9c4c2b4
617ee8e
c453e20
21e3692
4eaf86f
fb3ee6c
2885f48
471353e
9bde6b8
37e41d9
7df612b
0b296cf
5963fe2
3d2b801
853bd34
bdb42db
9509e95
f95df44
58d87fa
090415e
5cb269a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to parameterize (i.e., enable/disable) fault resolutions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fault resolutions are not implemented yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider including fault resolutions in the implementation plan.
The implementation steps are well-defined. However, consider adding a step to parameterize (enable/disable) fault resolutions, as mentioned in a previous comment. This would provide a more comprehensive implementation plan and align with the overall goal of customizable security measures.
🧰 Tools
🪛 Markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about inactive validators?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could disable this for inactive validators. Or even better, users should choose their configuration.