fix!: handle some panics #2205
Merged
fix!: handle some panics #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/provider
insumity
reviewed
Sep 3, 2024
| @@ -104,8 +111,8 @@ func (k Keeper) ProviderValidatorUpdates(ctx sdk.Context) []abci.ValidatorUpdate | |||
| for _, val := range bondedValidators[:maxValidators] { | |||
| nextValidator, err := k.CreateProviderConsensusValidator(ctx, val) | |||
| if err != nil { | |||
| k.Logger(ctx).Error("error when creating provider consensus validator", "error", err, "validator", val) | |||
| continue | |||
| return []abci.ValidatorUpdate{}, | |||
There was a problem hiding this comment.
Why is this returning an error now instead of simply logging? We want this to fail as a whole if we fail to create a single validator?
There was a problem hiding this comment.
I think so. Why would we fail to create a validator. If that happens, that's for sure something wrong with the state, right?
insumity
reviewed
Sep 3, 2024
| @@ -68,11 +68,14 @@ func TestQueueVSCPackets(t *testing.T) { | |||
| mocks := testkeeper.NewMockedKeepers(ctrl) | |||
| testkeeper.SetupMocksForLastBondedValidatorsExpectation(mocks.MockStakingKeeper, 0, []stakingtypes.Validator{}, 1) | |||
|
|
|||
| mocks.MockStakingKeeper.EXPECT().GetBondedValidatorsByPower(gomock.Any()).Return([]stakingtypes.Validator{}, nil).AnyTimes() | |||
There was a problem hiding this comment.
Is this indented correctly? Looks like it's fully on the left in comparison to the others.
There was a problem hiding this comment.
also fine for me, but gets confusing/wrong when I scale down the browser window
insumity
reviewed
Sep 3, 2024
insumity
approved these changes
Sep 3, 2024
bermuell
reviewed
Sep 3, 2024
p-offtermatt
reviewed
Sep 3, 2024
bermuell
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
getTotalPowerEndBlockVSUAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if the change is state-machine breakingCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!the type prefix if the change is state-machine breaking