Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: remove
stopTime
fromMsgRemoveConsumer
#2208fix!: remove
stopTime
fromMsgRemoveConsumer
#2208Changes from 11 commits
0870cb0
78a1459
f8e8829
48175e8
a34b9b5
ad70394
1186fa9
060bf60
8457336
2f7e04c
e41f7fd
ef5ca2b
eef6bb8
e1adcc5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 1 in proto/interchain_security/ccv/provider/v1/query.proto
GitHub Actions / break-check
Check failure on line 1 in proto/interchain_security/ccv/provider/v1/query.proto
GitHub Actions / break-check
Check failure on line 16 in proto/interchain_security/ccv/provider/v1/query.proto
GitHub Actions / break-check
Check failure on line 186 in proto/interchain_security/ccv/provider/v1/query.proto
GitHub Actions / break-check
Check failure on line 335 in proto/interchain_security/ccv/provider/v1/query.proto
GitHub Actions / break-check
Check failure on line 335 in proto/interchain_security/ccv/provider/v1/query.proto
GitHub Actions / break-check
Check failure on line 226 in proto/interchain_security/ccv/provider/v1/tx.proto
GitHub Actions / break-check
Check failure on line 231 in proto/interchain_security/ccv/provider/v1/tx.proto
GitHub Actions / break-check
Check failure on line 231 in proto/interchain_security/ccv/provider/v1/tx.proto
GitHub Actions / break-check
Check failure on line 231 in proto/interchain_security/ccv/provider/v1/tx.proto
GitHub Actions / break-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete the test function.
The changes made to stop the consumer chain using the new methods
SetConsumerPhase
andDeleteConsumerChain
are in line with the PR objectives. However, the test function is incomplete and has commented out code that needs to be implemented.Please complete the test function by implementing the following:
OnChanCloseConfirm
on the provider chain's channel end.Do you want me to open a GitHub issue to track this task?