Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: add message validation of signers (bring fix to main) #2216

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix!: add message validation of signers (bring fix to main) #2216

merged 1 commit into from
Sep 5, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Sep 4, 2024

Description

Closes: #XXXX

This was fixed in v5.2.0. This PR brings the fix to main and therefore it doesn't need changelog entries.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@sainoe @mpoke
Merge commit from fork
0a7309a 
* add fix

* Revert "test: Fix use of hardcoded cosmos... address (backport #2122) (#2142)"

This reverts commit d7af672.

* add fix

* revert nit

* call validateBasic

* Revert "call validateBasic"

This reverts commit 463caea5ce267cb8e1f529ccd38dddbf7338a10f.
@mpoke mpoke requested a review from a team as a code owner September 4, 2024 17:46
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Sep 4, 2024
@mpoke mpoke added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 0349c45 Sep 5, 2024
13 of 15 checks passed
@mpoke mpoke deleted the marius/signers branch September 5, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainoe sainoe sainoe approved these changes

@insumity insumity insumity approved these changes

Assignees
No one assigned
Labels
C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpoke @insumity @sainoe