Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update e2e permissionless tests #2251

Merged
merged 8 commits into from
Sep 11, 2024
Merged

test: update e2e permissionless tests #2251

merged 8 commits into from
Sep 11, 2024

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Sep 11, 2024 •
edited
Loading

Description

Permissionless ICS logic changed behaviour for consumer chain updates of launched chains.
No changes to initialization parameteres are accepted if chain is already launched
This PR adapts the e2e tests using ConsumerUpdates on launched chains.

Fix filename in changelogs

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@bermuell bermuell self-assigned this Sep 11, 2024
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Sep 11, 2024
@bermuell bermuell marked this pull request as ready for review September 11, 2024 08:24
@bermuell bermuell requested a review from a team as a code owner September 11, 2024 08:24
sainoe
sainoe approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@sainoe sainoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/e2e/actions.go Show resolved Hide resolved
MSalopek
MSalopek approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin approval.

@bermuell bermuell added this pull request to the merge queue Sep 11, 2024
@bermuell bermuell removed this pull request from the merge queue due to a manual request Sep 11, 2024
@bermuell bermuell added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 07ea628 Sep 11, 2024
15 checks passed
@bermuell bermuell deleted the bernd/permissionless_e2e+ branch September 11, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@sainoe sainoe sainoe approved these changes

@insumity insumity Awaiting requested review from insumity

@mpoke mpoke Awaiting requested review from mpoke

Assignees

@bermuell bermuell

Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bermuell @sainoe @MSalopek