-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update Permissionless ICS ADR to capture latest changes #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Docs
Assigned automatically by the PR labeler
C:ADR
Assigned automatically by the PR labeler
labels
Sep 12, 2024
insumity
force-pushed
the
insumity/update-ADR-019
branch
from
September 12, 2024 13:05
95113f0
to
570ffa7
Compare
mpoke
approved these changes
Sep 12, 2024
bermuell
reviewed
Sep 12, 2024
|
||
#### Initialize a Consumer Chain | ||
To move an Opt In consumer chain to its initialized phase, we issue a `MsgInitializeConsumer` message that is as follows: | ||
Note that `metadata` is a required field, while the `initialization_parameterrs` and `power_shaping_parameters` are optional and can later be set using `MsgUpdateConsumer`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Note that `metadata` is a required field, while the `initialization_parameterrs` and `power_shaping_parameters` are optional and can later be set using `MsgUpdateConsumer`. | |
Note that `metadata` is a required field, while the `initialization_parameters` and `power_shaping_parameters` are optional and can later be set using `MsgUpdateConsumer`. |
} | ||
``` | ||
|
||
#### Examples of Launching a Consumer Chain | ||
The figures below depict some examples of some of the phases a consumer chain resides in to launch. | ||
The figures below depict some examples of some of the phases a consumer chain resides before launching. | ||
|
||
![Examples of a launching consumer chain](./figures/adr19_flows_of_launching_a_consumer_chain.png) | ||
|
||
|
||
### Additional Modifications | ||
We need to perform multiple migrations. All state needs to be reindex based on a `consumerId` instead of the `chainId`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
We need to perform multiple migrations. All state needs to be reindex based on a `consumerId` instead of the `chainId`. | |
We need to perform multiple migrations. All state needs to be reindexed based on a `consumerId` instead of the `chainId`. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:
prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:
prefix in the PR titlemake build-docs
)