fix!: only validate active chains (backport #2266) #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
init commit (cherry picked from commit f4ae106)
github-actions
bot
added
C:Testing
mpoke
approved these changes
Sep 13, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Expect packet not to bounce if the chain is launched | ||
| providerKeeper.SetSlashMeter(ctx, math.NewInt(-1)) | ||
| providerKeeper.SetConsumerPhase(suite.providerCtx(), firstBundle.ConsumerId, providertypes.CONSUMER_PHASE_LAUNCHED) | ||
| ackResult, err = providerKeeper.OnRecvSlashPacket(ctx, packet, *slashPacketData) |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
See comment. There's no reason why a validator would have to validate a stopped chain.
Solution
Change
hasToValidateso queries return correct whether a validator has to validate.Also, modified jailing code so that from the moment a chain stops until it gets deleted, we cannot jail a validator for downtime.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if the change is state-machine breakingCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!the type prefix if the change is state-machine breakingThis is an automatic backport of pull request #2266 done by [Mergify](https://mergify.com).