Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: enable consumer to be relaunched after failed attempt #2271

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix!: enable consumer to be relaunched after failed attempt #2271

merged 2 commits into from
Sep 13, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Sep 13, 2024

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke requested a review from a team as a code owner September 13, 2024 15:20
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Sep 13, 2024
insumity
insumity approved these changes Sep 13, 2024 •
edited
Loading
View reviewed changes
@mpoke mpoke merged commit e196a63 into main Sep 13, 2024
14 of 15 checks passed
@mpoke mpoke deleted the marius/relaunch-consumer branch September 13, 2024 15:48
mergify bot pushed a commit that referenced this pull request Sep 13, 2024
@mpoke @mergify
fix!: enable consumer to be relaunched after failed attempt (#2271)
69f8893 
* enable consumer to be relaunched after failed attempt

* fix UT

(cherry picked from commit e196a63)
@mergify mergify bot mentioned this pull request Sep 13, 2024
Merged
21 tasks
mpoke added a commit that referenced this pull request Sep 13, 2024
@mergify @mpoke
fix!: enable consumer to be relaunched after failed attempt (backport #…
07f2ea1 
…2271) (#2272)

fix!: enable consumer to be relaunched after failed attempt (#2271)

* enable consumer to be relaunched after failed attempt

* fix UT

(cherry picked from commit e196a63)

Co-authored-by: Marius Poke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insumity insumity insumity approved these changes

Assignees
No one assigned
Labels
C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpoke @insumity