Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove duplicate event emission #2282

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix!: remove duplicate event emission #2282

merged 2 commits into from
Sep 20, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Sep 17, 2024

Description

Closes: #XXXX

CacheContext already automatically emits events on the parent context's EventManager when the caller executes the writeCache.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke requested a review from a team as a code owner September 17, 2024 13:33
@github-actions github-actions bot added C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Sep 17, 2024
@mpoke mpoke merged commit 47b786a into main Sep 20, 2024
13 of 14 checks passed
@mpoke mpoke deleted the marius/events-cached-ctx branch September 20, 2024 16:00
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
* remove duplicate event emission

* add changelog entry

(cherry picked from commit 47b786a)

# Conflicts:
#	x/ccv/provider/keeper/consumer_lifecycle.go
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
* remove duplicate event emission

* add changelog entry

(cherry picked from commit 47b786a)
mpoke added a commit that referenced this pull request Sep 20, 2024
fix!: remove duplicate event emission (#2282)

* remove duplicate event emission

* add changelog entry

(cherry picked from commit 47b786a)

Co-authored-by: Marius Poke <[email protected]>
p-offtermatt pushed a commit that referenced this pull request Sep 25, 2024
* fix!: remove duplicate event emission (#2282)

* remove duplicate event emission

* add changelog entry

(cherry picked from commit 47b786a)

# Conflicts:
#	x/ccv/provider/keeper/consumer_lifecycle.go

* fix backport

---------

Co-authored-by: Marius Poke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v4.5.x A:backport/v6.1.x C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants