-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add memo to IBC transfers of ICS rewards (backport #2290) #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add consumer ID to consumer genesis * add RewardMemo to token transfer * handle memo on provider side * fix democ tests * wip * add e2e-test * refactor consumer reward tests * add consumer migration info * add changelog * fix changelog filename --------- Co-authored-by: Simon Noetzlin <[email protected]> (cherry picked from commit 0d78295) # Conflicts: # UPGRADING.md # tests/e2e/actions.go # tests/e2e/state.go # tests/e2e/steps_democracy.go # tests/e2e/steps_inactive_vals.go # tests/e2e/test_driver.go # tests/e2e/testlib/types.go # tests/e2e/v4/state.go # x/ccv/consumer/migrations/v3/legacy_params.go # x/ccv/provider/ibc_middleware.go # x/ccv/provider/keeper/consumer_lifecycle.go # x/ccv/provider/keeper/consumer_lifecycle_test.go # x/ccv/provider/keeper/grpc_query.go # x/ccv/provider/types/errors.go # x/ccv/provider/types/msg.go # x/ccv/provider/types/msg_test.go # x/ccv/types/errors.go # x/ccv/types/shared_consumer.pb.go # x/ccv/types/shared_params.go
Cherry-pick of 0d78295 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
github-actions
bot
added
C:Testing
Assigned automatically by the PR labeler
C:x/consumer
Assigned automatically by the PR labeler
C:x/provider
Assigned automatically by the PR labeler
C:x/types
Assigned automatically by the PR labeler
labels
Sep 27, 2024
sainoe
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:Testing
Assigned automatically by the PR labeler
C:x/consumer
Assigned automatically by the PR labeler
C:x/provider
Assigned automatically by the PR labeler
C:x/types
Assigned automatically by the PR labeler
conflicts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1634
TODO:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if the change is state-machine breakingCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
the type prefix if the change is state-machine breakingThis is an automatic backport of pull request #2290 done by [Mergify](https://mergify.com).