Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: refactor consumer rewards #2323

Merged
merged 11 commits into from
Oct 4, 2024
Merged

feat!: refactor consumer rewards #2323

merged 11 commits into from
Oct 4, 2024

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Oct 2, 2024

Description

Skip the distribution of consumer rewards if the allocation to validators returns an error here.

Closes: #2292


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@sainoe sainoe requested a review from a team as a code owner October 2, 2024 15:17
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Oct 2, 2024
@sainoe sainoe marked this pull request as draft October 3, 2024 09:52
@sainoe sainoe changed the title feat!: refactor consumer rewards feat!: refactor consumer rewards 1/2 Oct 3, 2024
@sainoe sainoe changed the title feat!: refactor consumer rewards 1/2 feat!: refactor consumer rewards Oct 3, 2024
@sainoe sainoe marked this pull request as ready for review October 3, 2024 10:31
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sainoe sainoe enabled auto-merge October 3, 2024 12:42
@sainoe sainoe disabled auto-merge October 3, 2024 13:05
@sainoe sainoe enabled auto-merge October 3, 2024 13:05
@sainoe sainoe added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 4, 2024
@sainoe sainoe added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 9d224a3 Oct 4, 2024
17 of 18 checks passed
@sainoe sainoe deleted the sainoe/distrib-refactor-2 branch October 4, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICS rewards that fail distribution are lost in the distribution module
3 participants