Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: enable the submission of allowlisted reward denoms #2326

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

insumity
Copy link
Contributor

@insumity insumity commented Oct 3, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@insumity insumity marked this pull request as ready for review October 3, 2024 11:32
@insumity insumity requested a review from a team as a code owner October 3, 2024 11:32
@insumity insumity changed the title fix!: allow the submission of denoms fix!: enable the submission of allowlisted reward denoms Oct 3, 2024
@insumity insumity marked this pull request as draft October 3, 2024 11:38
@github-actions github-actions bot added C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler labels Oct 3, 2024
@github-actions github-actions bot added the C:Docs Assigned automatically by the PR labeler label Oct 3, 2024
@insumity insumity marked this pull request as ready for review October 3, 2024 12:30
docs/docs/build/modules/02-provider.md Outdated Show resolved Hide resolved
x/ccv/provider/types/msg.go Show resolved Hide resolved
@MSalopek
Copy link
Contributor

MSalopek commented Oct 4, 2024

Tests failing intermittently but passing locally.

@sainoe sainoe self-requested a review October 4, 2024 14:36
@MSalopek MSalopek disabled auto-merge October 4, 2024 14:41
@MSalopek MSalopek merged commit 47cd04e into main Oct 4, 2024
16 of 20 checks passed
@MSalopek MSalopek deleted the insumity/fix-CLIs branch October 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Docs Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants