Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: validate initial height and set default values for init consumer params #2357

Merged
merged 8 commits into from
Oct 18, 2024
Merged

fix!: validate initial height and set default values for init consumer params #2357

merged 8 commits into from
Oct 18, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Oct 16, 2024

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke requested a review from a team as a code owner October 16, 2024 17:26
@github-actions github-actions bot added C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler labels Oct 16, 2024
MSalopek
MSalopek approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval but please check evmos-like chain names.

x/ccv/provider/types/msg_test.go Show resolved Hide resolved
MSalopek
MSalopek reviewed Oct 17, 2024
View reviewed changes
x/ccv/types/params.go
// than the default unbonding period on the provider, where the provider uses
// the staking module default.
DefaultConsumerUnbondingPeriod = stakingtypes.DefaultUnbondingTime - 7*24*time.Hour
DefaultConsumerUnbondingPeriod = stakingtypes.DefaultUnbondingTime - 24*time.Hour
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Contributor

@insumity insumity Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unbonding pausing anymore, so I guess no reason for it to be much smaller (?) So, we can have longer trust period this way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

@MSalopek
Copy link
Contributor

I'm trying to figure out the revision height problem locally using some externally supplied data. Let's pause this for now (unless you're fixing the tests).

@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Oct 17, 2024
@github-actions github-actions bot added the C:Build Assigned automatically by the PR labeler label Oct 18, 2024
@mpoke mpoke added this pull request to the merge queue Oct 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 18, 2024
@mpoke @sainoe
fix!: validate initial height and set default values for init consume…
18e4459 
…r params (#2357)

* add initial height validation

* set default consumer init params on creation

* add changelog entries

* add test for evmos like chain ID

* fix UTs

* set the default RevisionHeight to 1

* fix e2e tests

* use temporary patched Hermes version in compability tests

---------

Co-authored-by: Simon Noetzlin <[email protected]>
Merged via the queue into main with commit c2a1c76 Oct 18, 2024
15 checks passed
@mpoke mpoke deleted the marius/validate-initial-height branch October 18, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@insumity insumity insumity approved these changes

Assignees
No one assigned
Labels
C:Build Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpoke @MSalopek @insumity @sainoe