Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: allow the chain id to be updated if the chain has not yet launched #2378

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

insumity
Copy link
Contributor

@insumity insumity commented Oct 29, 2024

Description

Problem
Some consumer chains would like to reserve a consumerId but without yet knowing their chainId. Currently, to reserve the consumerId, you have to send a MsgRegisterConsumer that also gets the chainId as a parameter and chainId cannot later be changed.

Solution
Introduce new_chain_id in MsgUpdateConsumer so that a consumer chain can update its chainId after registration. Note that the chainId can only be updated before the consumer chain launches.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Oct 29, 2024
@insumity insumity force-pushed the insumity/make-chain-id-updateable branch from 81907cb to a7fa6e6 Compare October 29, 2024 11:03
@github-actions github-actions bot added the C:Docs Assigned automatically by the PR labeler label Oct 29, 2024
@insumity insumity marked this pull request as ready for review October 29, 2024 11:07
@insumity insumity requested a review from a team as a code owner October 29, 2024 11:07
@insumity insumity changed the title fix!: allow the chain id to be updated if the chain has not yet launched feat!: allow the chain id to be updated if the chain has not yet launched Oct 29, 2024
@insumity insumity linked an issue Oct 30, 2024 that may be closed by this pull request
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. Just make sure to correctly validate the new chain ID.

x/ccv/provider/types/msg.go Outdated Show resolved Hide resolved
x/ccv/provider/keeper/msg_server.go Show resolved Hide resolved
x/ccv/provider/keeper/msg_server.go Show resolved Hide resolved
@insumity insumity force-pushed the insumity/make-chain-id-updateable branch from 45d31f6 to 506bb3c Compare November 5, 2024 12:14
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@insumity insumity added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@mpoke mpoke added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@mpoke mpoke added this pull request to the merge queue Nov 6, 2024
@mpoke mpoke removed this pull request from the merge queue due to a manual request Nov 6, 2024
@mpoke mpoke merged commit af5d7a4 into main Nov 6, 2024
21 checks passed
@mpoke mpoke deleted the insumity/make-chain-id-updateable branch November 6, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Docs Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Make it possible to update chain id
3 participants