build: update cosmos-sdk to v0.50.7 #128
Conversation
Bump go version
|
Warning Rate limit exceeded@raynaudoe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 2 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent updates primarily focus on upgrading the Dockerfile to use newer base images and versions for building Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
Dockerfile (2)
Line range hint
32-32: Use WORKDIR to switch to a directory.Hadolint warning DL3003 suggests using WORKDIR instead of chaining RUN commands for directory changes. This can simplify the Dockerfile and make it more readable.
- RUN cd plugins/cosmos-hub && make plugin + WORKDIR /go/src/github.com/cosmos/rosetta/plugins/cosmos-hub + RUN make plugin + WORKDIR /go/src/github.com/cosmos/rosetta
Line range hint
42-42: Use COPY instead of ADD for files and folders.Hadolint error DL3020 recommends using COPY instead of ADD for better clarity and because ADD has additional features which are not required here.
- ADD scripts/entrypoint.sh /scripts/entrypoint.sh + COPY scripts/entrypoint.sh /scripts/entrypoint.sh
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (1)
- Dockerfile (2 hunks)
Additional context used
Hadolint
Dockerfile
[warning] 32-32: Use WORKDIR to switch to a directory (DL3003)
[error] 42-42: Use COPY instead of ADD for files and folders (DL3020)
Additional comments not posted (3)
Dockerfile (3)
4-4: Updated base image forcosmostogolang:1.22.This change aligns with the PR objectives to bump the Go version to 1.22.
13-13: Updatedcosmos-sdkversion tov0.50.7.This change is consistent with the PR objectives to bump the
cosmos-sdkversion tov0.50.7.
19-19: Updated base image forrosettatogolang:1.22.This change aligns with the PR objectives to bump the Go version to 1.22.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
CHANGELOG.md (4)
Line range hint
118-118: Consider adding the preposition "due to" for clarity.- due event type changes. + due to event type changes.
Line range hint
92-92: Remove the trailing space on this line.- +
Line range hint
84-84: Add a blank line above this heading for better readability and to adhere to Markdownlint rules.+ ## [v0.50.3+1](https://github.com/cosmos/rosetta/releases/tag/v0.50.3+1) 2024-01-07
Line range hint
83-83: Surround this list with blank lines to adhere to Markdownlint rules.+ > v0.50.3 has been retracted due to a mistake in dependencies. Please use v0.50.3+1 instead. +
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
LanguageTool
CHANGELOG.md
[uncategorized] ~118-~118: Possible missing preposition found. (AI_HYDRA_LEO_MISSING_TO)
Context: ... version of Tendermint isv0.37+, due event type changes.** ### Improvements * [#...
Markdownlint
CHANGELOG.md
92-92: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
84-84: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
83-83: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
Additional comments not posted (1)
CHANGELOG.md (1)
43-48: LGTM! The changelog entry for v0.50.7 is correctly formatted and follows the changelog guidelines.
CHANGELOG.md
Outdated
| @@ -40,6 +40,12 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| * [123](https://github.com/cosmos/rosetta/pull/123) Correctly parse cometBFT finalize block. | |||
There was a problem hiding this comment.
This bug fix should be part of the release.
Summary by CodeRabbit
gaiaandrosettato use newer versions.CHANGELOG.mdreflecting the upgrade tocosmos-sdkversionv0.50.7.