refactor: cosmos-sdk v0.50 upgrade and multi zone enhancements #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added plugins feature and reflection features * fixed minor sdkTx variables issue * Roll back some changes on config.go * fixed makefile build command * improvements over lint * Added nolint ant changed variable name * fix .gitworkflow build * fix .gitworkflow build * Added makefile build plugin steps * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * gofumpt on project * skiped a test due to reliance on an experimental feature of cosmos v0.46.0-beta * build plugin before test * build plugin before test * fixed failing test * fix make test * added docs * small refactor on variable names
* added plugins feature and reflection features * fixed minor sdkTx variables issue * Roll back some changes on config.go * fixed makefile build command * improvements over lint * Added nolint ant changed variable name * fix .gitworkflow build * fix .gitworkflow build * Added makefile build plugin steps * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * gofumpt on project * skiped a test due to reliance on an experimental feature of cosmos v0.46.0-beta * build plugin before test * build plugin before test * fixed failing test * fix make test * added docs * small refactor on variable names * Updated documentation and added --plugin flag * updated install step on README * lint fix * updated docs
* changed go.mod name, renamed dependencies on rosetta, adapted methods and uses of cosmos-sdk, upgraded dependencies * fixed all code errors * improvements over parsing * fees and gas parsing * remmoved validation on message due to deprecation (it should be validated on the server side) * solved issue on missing tx tipper * added codec types * fixed interface registre addr issue * improvements * fixed converter tests * commented plugin_test.go due to some modules not being available at v0.50 yet * improved code, moved parsing functions to utils.go * solved comments, fixed lint and added utils.go for parsing * fixed comment on cast variables * lint comments * Commented ibc-go dependdency until upgrade * added type assertion error handlinhg * updated go.sum
bizk
changed the title
raynaudoe
approved these changes
Aug 30, 2023
julienrbrt
requested changes
Aug 30, 2023
go.mod
Outdated
| @@ -1,100 +1,124 @@ | |||
| module cosmossdk.io/tools/rosetta | |||
| module cosmossdk.io/rosetta | |||
There was a problem hiding this comment.
I think it should be github.com/cosmos/rosetta, the vanity url isn't configured for this.
raynaudoe
approved these changes
Sep 1, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades dependencies to latest cosmos-sdk v0.50.x and also improves project multizone capabilities as type reflection through grpc endpoints.
Work description:
changed go.mod name, renamed dependencies on rosetta, adapted methods and uses of cosmos-sdk, upgraded dependencies
fixed all code errors
improvements over parsing
fees and gas parsing
remmoved validation on message due to deprecation (it should be validated on the server side)
solved issue on missing tx tipper
added codec types
fixed interface registre addr issue
improvements
fixed converter tests
commented plugin_test.go due to some modules not being available at v0.50 yet
improved code, moved parsing functions to utils.go
solved comments, fixed lint and added utils.go for parsing
fixed comment on cast variables
lint comments
Commented ibc-go dependdency until upgrade
added type assertion error handlinhg
updated go.sum