Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve rosetta-ci test #71

Merged
merged 15 commits into from
Jan 18, 2024
Merged

feat: improve rosetta-ci test #71

merged 15 commits into from
Jan 18, 2024

Conversation

bizk
Copy link
Contributor

@bizk bizk commented Jan 3, 2024

This PR aims to move logic out of github rosetta-ci workflow into a makefile + script instructions.

@bizk bizk self-assigned this Jan 3, 2024
.github/workflows/rosetta-cli-test.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
scripts/simapp-start-node.sh Show resolved Hide resolved
bizk and others added 2 commits January 8, 2024 16:32
@bizk bizk changed the title feature: improve rosetta-ci test feat: improve rosetta-ci test Jan 9, 2024
@bizk bizk marked this pull request as ready for review January 15, 2024 22:26
Copy link

coderabbitai bot commented Jan 15, 2024

Walkthrough

The changes reflect a streamlining of the build and test processes in the repository. The workflows have been simplified, the Makefile has seen the addition of new targets and the removal of others, adjusting the build and test commands accordingly. The README.md has been updated to align with the new build command, and a new script for starting a Cosmos SDK node has been added.

Changes

File Summary of Changes
.github/workflows/build.yml Removed comments; changed make rosetta to make build in Build Rosetta job.
.github/workflows/rosetta-cli-test.yaml, .github/workflows/test.yml Simplified workflows by removing specific setup steps and flags.
Makefile Added plugin and docker targets; removed rosetta and rosetta-cli targets; modified test target; added test-rosetta-ci target; replaced go-lint-all.bash with `gog-lint-all.bash.
README.md Updated build command from make rosetta to make build.
scripts/simapp-start-node.sh Added script for starting a Cosmos SDK node.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

scripts/simapp-start-node.sh Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@bizk bizk requested a review from raynaudoe January 16, 2024 13:18
Copy link
Contributor

@raynaudoe raynaudoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bizk bizk merged commit 47afcef into main Jan 18, 2024
8 of 9 checks passed
@bizk bizk deleted the feature/ghworkflows branch January 18, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants