Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform io update: add CI build of library and examples for both ESP8266 and ESP32 #14

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

rob040
Copy link
Contributor

@rob040 rob040 commented Jan 6, 2024

I added CI build of library and examples for both ESP8266 and ESP32
with possible exceptions of examples that aren't compatible for either CPU's.
I have chosen a generic board type for each processor type, and that is controlled all in the batch file, unrelated to settings in platformio.ini.

rob040 added 2 commits January 6, 2024 02:11
Fix generic issues:
    send favicon.ico when available in FS.
    fix MDNS.begin arg;incompatible; compile error on PIO but not on Arduino IDE(?).
    Fix unused static int i; compile error on Arduino IDE but not on PIO.
    Transfer IP addresses in json as string (2x), not LE integer (not portable).
    TODO: update setup.htm "esp-ip" to receive IP address as string iso. int (simpler).
    Update two related examples simpleServer & simpleServerCaptive.
@rob040
Copy link
Contributor Author

rob040 commented Jan 6, 2024

Hi, I now see that you have some continuous integration as github workflow running (new to me), which does something similar to what I attempt with my pio CI batch file.
Some of those workflow checks are failing, but it doesn't tell what.
Now I have merged your changes and ran the batch file, I see what's wrong. it is change ff061f7 on customHTML.ino, line 212 + 214.

@rob040
Copy link
Contributor Author

rob040 commented Jan 6, 2024

The reported errors are fixed with PR #15

@cotestatnt cotestatnt merged commit 00ad3ff into cotestatnt:master Jan 7, 2024
18 of 20 checks passed
@rob040 rob040 deleted the PlatformIO branch January 7, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants