Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CMake >= 3.5 #22

Closed
wants to merge 1 commit into from
Closed

Require CMake >= 3.5 #22

wants to merge 1 commit into from

Conversation

cottsay
Copy link
Owner

@cottsay cottsay commented Feb 13, 2024

This should address two warnings:

CMake Warning (dev) at CMakeLists.txt:1 (project):
  cmake_minimum_required() should be called prior to this top-level project()
  call.  Please see the cmake-commands(7) manual for usage documentation of
  both commands.
CMake Deprecation Warning at CMakeLists.txt:3 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

@cottsay cottsay self-assigned this Feb 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4cf04f) 51.30% compared to head (1090745) 51.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   51.30%   51.23%   -0.07%     
==========================================
  Files          22       22              
  Lines        2912     2912              
==========================================
- Hits         1494     1492       -2     
- Misses       1418     1420       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay closed this in #24 Feb 19, 2024
@cottsay cottsay deleted the cottsay/cmake_version branch April 24, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants