More compiler warnings, and sanitizers, in CMake builds #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An inline function (not method!) in a header file shouldn't be declared `static` or it'll be copied into every compilation unit that uses it.
snej
force-pushed
the
warnings
branch
6 times, most recently
from
66ad5fc
to
529d81a
Compare
and removed Channel.cc which was empty
It's timing-sensitive, and in particular has started failing now that sanitizers are enabled. All it seems to do is check that an unsorted query is faster than a sorted one.
1. The replicator's pending-documents API would leak a Checkpointer object on each call, because it was allocated with a bare `new` and not deleted in the destructor. 2. The query translator would leak a locale string when parsing a COLLATE expression, because the CollateNode class contained a Collation object, which wasn't freed by the arena allocator. 3. c4db_collectionNames and c4db_scopeNames would leak Fleece mutable arrays if the db is closed, due to an exception being thrown.
- Turned off -Wformat in Linux builds since it causes warnings everywhere we pass int64_t through a printf-type function, which is not actually a problem. - Suppressed a false "control reaches end of non-void function" in ExprNodes.cc. - Fixed a few places in BLIP where values of different enum types are or-ed together.
|
Code Coverage Results:
|
It would be cleaner to fix this by editing c4LocalReplicator.hh in the couchbase-lite-core-EE repo, but that would involve more work wrestling with Git repos.
|
With this PR, will it compile with the master branch of fleece? |
borrrden
requested changes
Sep 27, 2024
|
@borrrden the fleece reference actually points to a commit that has same content as master (via git diff ..master). I changed it to be actual master branch. |
borrrden
approved these changes
Oct 2, 2024
jianminzhao
added a commit
that referenced
this pull request
Oct 8, 2024
CBL-6148: Update Replication Protocol for 4.0 (#2140) 683737c Fixed incorrect SchemaVersion::Current (#2153) 44a0d4a Make test logs readable in CLion (#2143) d53db2e More compiler warnings, and sanitizers, in CMake builds (#2138) 23441ce CBL-6288: Disable Replication tests in Actions. (#2151) 56f7749 Fixed UB when a CollectionChangeObserver deletes itself in its callback (#2123) 6eb8ec8 Pick up latest from the master branch of fleece. (#2145) a177348 QueryTranslator: Implemented predictive index support (#2141) CBL-5616: Update SG docker version (again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new CMake options:
LITECORE_WARNINGS_HARDCOREenables all compiler warnings except for a few dozen that are too onerous, plus-Werror.LITECORE_SANITIZEenables the Clang Address and UB sanitizers.Currently these are only supported in Clang builds, and ignored with other compilers. They are propagated to Fleece (see couchbase/fleece#239)
Also made source changes to fix some new warnings produced by this.