Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration options for storageType for REST API #1431

Closed
wants to merge 1 commit into from

Conversation

swaheed2
Copy link
Contributor

@swaheed2 swaheed2 commented Sep 7, 2016

accept optional body for do_PUT_Database with storageType as key.

Example:


var data = {
    storageType : "ForestDB"
    //ForestDB
    //SQLite
};

accept optional body for do_PUT_Database with storageType as key
@ajres ajres added the review label Sep 7, 2016
@hideki hideki added this to the 1.4.0 milestone Sep 7, 2016
@hideki
Copy link

hideki commented Sep 7, 2016

Hi @swaheed2,
API change is for cross-platform item. We need to talk with other platform engineers. Please wait for a while.

@swaheed2
Copy link
Contributor Author

swaheed2 commented Sep 7, 2016

No problem.

FYI. I tested it on Android using these steps and it works: (couchbaselabs/Couchbase-Lite-PhoneGap-Plugin#79)

@hideki
Copy link

hideki commented Sep 9, 2016

Additional comment from team member:

  • Do we need to support encryption?

@hideki
Copy link

hideki commented Sep 17, 2016

Hi @swaheed2
We are internally working for this item. API could be different from you proposed. We will track this item here. So I will closed this PR.
Thank you for your contributions!

@hideki hideki closed this Sep 17, 2016
@hideki hideki removed the review label Sep 17, 2016
@swaheed2 swaheed2 deleted the patch-1 branch September 17, 2016 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants