Don’t allow reachability for P2P / loopback

P2P may not need it, and loopback doesn’t make sense on iOS
couchbase · Oct 27, 2018 · 9aebf28 · 9aebf28
1 parent 6ce8317
commit 9aebf28
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Couchbase.Lite.Shared/API/Sync/Replicator.cs b/src/Couchbase.Lite.Shared/API/Sync/Replicator.cs
@@ -484,9 +484,14 @@ private void StartReachabilityObserver()
                 return;   
             }
 
+            var remoteUrl = (Config.Target as URLEndpoint)?.Url;
+            if(remoteUrl == null) {
+                return;
+            }
+
             _reachability = Service.GetInstance<IReachability>() ?? new Reachability();
             _reachability.StatusChanged += ReachabilityChanged;
-            _reachability.Url = Config.RemoteUrl;
+            _reachability.Url = remoteUrl;
             _reachability.Start();
         }
 

diff --git a/src/Couchbase.Lite.Support.Apple/iOS/Support/iOSReachability.cs b/src/Couchbase.Lite.Support.Apple/iOS/Support/iOSReachability.cs
@@ -104,7 +104,7 @@ public void Start()
         {
             _queue.DispatchSync(() =>
             {
-                if (_started) {
+                if (_started || Url?.IsLoopback == true) {
                     return;
                 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -104,7 +104,7 @@ public void Start() @@
             {
                 _queue.DispatchSync(() =>
                 {
-                    if (_started) {
+                    if (_started || Url?.IsLoopback == true) {
                         return;
                     }
@@ Expand Down @@