RSCBC-12: Implement tracing #245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt-Woz
force-pushed
the
tracing_and_metrics
branch
3 times, most recently
from
2e65ddb to
008c77c
Compare
Matt-Woz
force-pushed
the
tracing_and_metrics
branch
from
008c77c to
58a4e69
Compare
Matt-Woz
commented
Feb 27, 2025
| if !log_output.is_empty() { | ||
| match serde_json::to_string(&log_output) { | ||
| Ok(log_output_str) => { | ||
| tracing::warn!("Operations over threshold: {}", log_output_str) |
There was a problem hiding this comment.
I think given we're using tracing for spans already, it probably makes sense to convert all of our logging to use tracing instead, since tracing can be configured to also emit log records. See the tracing docs on log crate compatibility
| @@ -462,6 +489,7 @@ impl Agent { | |||
| info!("Orphan : {:?}", packet); | |||
| }), | |||
| disable_decompression: opts.compression_config.disable_decompression, | |||
| tracing: tracing.clone(), | |||
There was a problem hiding this comment.
I'm not sure this is the best way to get the tracing component down the KV stack to the KvClient, but I can't see a nicer way -- Given spans can be manipulated w/ static functions, I did also experiment with just passing the TracingConfig (i.e. ClusterLabels) in with the KvConfig, but I don't think it was much better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.