AV-55075: add Tab Sync Group #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed that on https://docs-staging.couchbase.com/server/current/guides/updating-data.html the 3rd set of tabs don't synchronise, because `cbc-subdoc` is a different string than `cbc` This commit sets them all in the same "sync group" so they match for e.g. .NET, Java, etc. (cbc and cbc-subdoc still won't synchronize though. That doesn't seem to be customizable from https://github.com/asciidoctor/asciidoctor-tabs#tabs-sync Consider rewording both to `cbc` or `CLI` or similar if that would be desirable.)
simon-dew
requested changes
Jun 8, 2023
There was a problem hiding this comment.
This works beautifully, and vastly improves the user experience for tabs. I'd be happy to change the cbc-subdoc tabs to match the cbc tabs to ensure that they sync correctly. But:
- This affects more than just the updating-data page; need update all pages with
cbc/cbc-subdoctabs. - We need to decide on what to call the unified command line tabs. The obvious answer would be to rename
cbc-subdoctocbc. But this is inaccurate as they are two separate tools. Maybe better to standardise onCLIfor the CLI tabs, as you suggested. - Just to note that the links to the SDK API documentation is broken. Should be https://docs.couchbase.com/sdk-api/couchbase-c-client/md_doc_2cbc-subdoc.html
Happy for this to be a separate PR from this ticket or a new ticket.
remove `tab-sync-group` parameter, and instead rename all of `cbc` and `cbc-subdoc` to `CLI` so that they inherit the useful default behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that on https://docs-staging.couchbase.com/server/current/guides/updating-data.html the 3rd set of tabs don't synchronise, because
cbc-subdocis a different string thancbcThis commit sets them all in the same "sync group" so they match for e.g. .NET, Java, etc.
(cbc and cbc-subdoc still won't synchronize though. That doesn't seem to be customizable from https://github.com/asciidoctor/asciidoctor-tabs#tabs-sync Consider rewording both to
cbcorCLIor similar if that would be desirable.)