Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry #29

Closed
wants to merge 1 commit into from
Closed

Poetry #29

wants to merge 1 commit into from

Conversation

arnaudgelas
Copy link

No description provided.

@arnaudgelas arnaudgelas force-pushed the poetry branch 2 times, most recently from 60e8ff0 to a0663dd Compare November 8, 2021 19:54
black, isort, flake8, mypy and bandit are added as dev dependencies.
@uuazed
Copy link
Member

uuazed commented Nov 8, 2021

In my opinion, this PR is doing way too many things at once, which makes it hard (and no fun) to review. Also, you are not giving any explanations (or refer to open tickets), so it*s hard to see what problems you are solving.

I do understand what you are trying to do and I really appreciate your contribution. However, it might make sense to split this up and create dedicated PRs. And I really don*t like auto-formatting code with black...

@arnaudgelas
Copy link
Author

arnaudgelas commented Nov 10, 2021

Here is the first PR to introduce poetry as a dependency management tool:

#31

Once this is merged, I can bring little by little the rest.

@uuazed I don't care so much about the format, nor the tool, being used to format code as long as it is being automated and enforced. So if you have any preference for any tool, format, please go ahead and submit one PR 😉 !

@uuazed
Copy link
Member

uuazed commented Nov 12, 2021

Here is the first PR to introduce poetry as a dependency management tool:

#31

Once this is merged, I can bring little by little the rest.

@uuazed I don't care so much about the format, nor the tool, being used to format code as long as it is being automated and enforced. So if you have any preference for any tool, format, please go ahead and submit one PR wink !

Thanks for splitting it into smaller chunks!

Regarding black, actually I do not like automated code formatting - I want my code to look like I wrote and pushed it. However, I do believe linting is important and we should enforce a certain codestyle by running static code analysis tools. We already run pylint, we can add mypy and others if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants