Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport copy-to-clipboard ui root fallback and fix ui root config #30

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

countableSet
Copy link
Owner

backport commit from upstream https://gitlab.com/antora/antora-ui-default/-/commit/91de243e4cd1d84effe43af31c1e01e7231ba568

  • also remove uiRootPath from header root script since it was commented out in the upstream
  • fix data-ui-root-path="_" to actually use the variable 🤦🏻‍♀️
<script id="site-script" src="../_/js/site.js" data-ui-root-path="../_"></script>

safari console:

> document.getElementById('site-script').dataset
< DOMStringMap = $3
uiRootPath: "../_"
DOMStringMap Prototype

cc #28

@countableSet countableSet merged commit 7340861 into master Aug 13, 2024
3 checks passed
@countableSet countableSet deleted the copy-script branch August 13, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant