Fix data default value #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chung1905
force-pushed
the
fix-data-default-value
branch
from
6bdb7c6 to
c684ecc
Compare
|
I pushed a redundant commit, removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I did a commit to fix the issue #75 .
The error happens when
data-show-default-optionis set to false and thedata-default-valueof country field has index === 0, so the plugin thinks no country is selected, and it doesn't search fordata-default-valueof region field.I did a fix on both vanilla javascript and jquery.
Can you please check.
Thanks.