Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LW.1.2,LF.8.1.1 Alias #2749

Closed
wants to merge 2 commits into from
Closed

Conversation

Mydtlwn
Copy link
Contributor

@Mydtlwn Mydtlwn commented Aug 24, 2024

No description provided.

@DailyCovidCases
Copy link

DailyCovidCases commented Oct 21, 2024

I found something incorrect here:
https://github.com/cov-lineages/pango-designation/blob/master/lineage_notes.txt
Screenshot (269)
Correction:
LF.8 Alias of B.1.1.529.2.86.1.1.16.1.8, S:M153I, C3244T, A18432T, C27110T
LF.8.1 Alias of B.1.1.529.2.86.1.1.16.1.8.1, S:S31F
LF.8.1.1 Alias of B.1.1.529.2.86.1.1.16.1.8.1.1, S:T22N
ND.1 Alias of B.1.1.529.2.86.1.1.16.1.8.1.1.1, ORF1a:L4391F (or LF.8.1.1.1)
ND.1.1 Alias of B.1.1.529.2.86.1.1.16.1.8.1.1.1.1, S:K478T (or LF.8.1.1.1.1)
ND.2 Alias of B.1.1.529.2.86.1.1.16.1.8.1.1.2, S:K478E (or LF.8.1.1.2)
ND.3 Alias of B.1.1.529.2.86.1.1.16.1.8.1.1.3, S:K478I (or LF.8.1.1.3)

@Mydtlwn
Copy link
Contributor Author

Mydtlwn commented Oct 21, 2024

@corneliusroemer

1 similar comment
@Mydtlwn
Copy link
Contributor Author

Mydtlwn commented Oct 21, 2024

@corneliusroemer

@Mydtlwn
Copy link
Contributor Author

Mydtlwn commented Oct 21, 2024

The long-unfixed Alias Bug has led to more Alias Bugs involving LW.1.2, LF.8.1.1, and the ND family, with a duration spanning from August to October.

@Mydtlwn
Copy link
Contributor Author

Mydtlwn commented Oct 21, 2024

@xz-keg

@Mydtlwn
Copy link
Contributor Author

Mydtlwn commented Oct 21, 2024

I suggest fixing the bug directly on the main branch after reviewing the files, as this bug already encompasses alias errors across the entire LW.1.2 and LF.8.1.1 families.

@Mydtlwn
Copy link
Contributor Author

Mydtlwn commented Oct 21, 2024

The error in LW.1.2 lies in writing the last digit of the alias as '.1', while the error in LF.8.1.1 and subsequent versions is missing a '.1'. Such minor errors are prone to occur in lineages like '.1.1.1'.

@Mydtlwn
Copy link
Contributor Author

Mydtlwn commented Oct 21, 2024

DailyCovidCases

@Mydtlwn
Copy link
Contributor Author

Mydtlwn commented Oct 21, 2024

@DailyCovidCases

@DailyCovidCases
Copy link

@DailyCovidCases
Go to this web: #2807

@Mydtlwn
Copy link
Contributor Author

Mydtlwn commented Oct 21, 2024

In your request #2807, please click on the 'Resolve Conflict' button. Check my file to see what differences there are compared to yours, and make the necessary changes accordingly. Once it's approved on that end, I can close it here.

FedeGueli added a commit to FedeGueli/pango-designation that referenced this pull request Oct 21, 2024
I re proposed this pull request originally found in cov-lineages#2749,
i have corrected also ND.1,ND.1.1 ,ND.2 and ND.3 aliases
FedeGueli added a commit to FedeGueli/pango-designation that referenced this pull request Oct 21, 2024
I propose here a pull request that includes the already existing PR cov-lineages#2749
Changes are made to aliases of LW.1.2, LF.8.1.1 ND.1 ND.1.1 ND.2 ND.3
@FedeGueli
Copy link
Contributor

i have proposed one only PR encompassing all typos to be corrected : #2808 you can close this one.

@Mydtlwn Mydtlwn closed this Oct 21, 2024
corneliusroemer pushed a commit that referenced this pull request Oct 21, 2024
I propose here a pull request that includes the already existing PR #2749
Changes are made to aliases of LW.1.2, LF.8.1.1 ND.1 ND.1.1 ND.2 ND.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants