Skip to content

Commit

Permalink
chore: use github_env (#1377)
Browse files Browse the repository at this point in the history
<!-- For Coveo Employees only. Fill this section.

CDX-XXX

-->

## Proposed changes

<!--
Explains what are you changing in the code and provide links to relevant
issues.
This doesn't need to be over-technical, a good summary of the issues
with good explanations of the decisions should be enough.
 -->

## Breaking changes

<!--
    Remove this section if the PR does not include any breaking change

If your changes includes some breaking changes in the code, thoroughly
explains:
        - What are the breaking changes programmatically speaking.
- What is the impact on the end-user (e.g. user cannot do X anymore).
        - What motivates those changes.
-->

## Testing

- [ ] Unit Tests:
<!-- Did you write unit tests for your feature? If not, explains why?
-->
- [ ] Functionnal Tests:
<!-- Did you write functionnal tests for your feature? If not, explains
why? -->
- [ ] Manual Tests:
<!-- How did you test your changeset?  -->
  • Loading branch information
louis-bompart authored Oct 27, 2023
1 parent 86f0f1a commit 1d9c987
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ jobs:
echo 'snapshotsPath<<EOF'
git diff --name-only **/*.snap
echo EOF
} >> "$GITHUB_OUTPUT"
} >> "$GITHUB_ENV"
- name: Upload Jest Snapshots
if: ${{ env.snapshotsPath != ''}}
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3
Expand Down Expand Up @@ -207,15 +207,15 @@ jobs:
- name: Build
run: npm run build
- name: Tests
run: npm run test:ci:snap
run: npm run test
- name: Find modified Snapshots
id: snapshots-path
run: |
{
echo 'snapshotsPath<<EOF'
git diff --name-only **/*.snap
echo EOF
} >> "$GITHUB_OUTPUT"
} >> "$GITHUB_ENV"
- name: Upload Jest Snapshots
if: ${{ env.snapshotsPath != ''}}
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3
Expand Down

0 comments on commit 1d9c987

Please sign in to comment.