Skip to content

Commit

Permalink
fix: use shell:powershell & ps1 on Windows (#1462)
Browse files Browse the repository at this point in the history
<!-- For Coveo Employees only. Fill this section.

CDX-1560

-->

## Proposed changes

Since NodeJS 20.12.2 (and it's equivalent on Node 18), you cannot use
spawnSync (or equivalent) to execute a `.cmd`, so instead two-fold fix:
1. Target `.ps1` instead of `.cmd`
2. Use PowerShell as the terminal being used when using Windows
  • Loading branch information
louis-bompart authored May 3, 2024
1 parent d296470 commit a32405b
Show file tree
Hide file tree
Showing 33 changed files with 240 additions and 120 deletions.
1 change: 1 addition & 0 deletions .github/actions/e2e-run/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ runs:
run: |
git config --global core.autocrlf false
git config --global core.eol lf
npm i -g npm@latest
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
with:
cache: 'npm'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
run: |
git config --global core.autocrlf false
git config --global core.eol lf
npm i -g npm@latest
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
with:
Expand All @@ -58,6 +59,7 @@ jobs:
run: |
git config --global core.autocrlf false
git config --global core.eol lf
npm i -g npm@latest
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
with:
Expand Down Expand Up @@ -98,6 +100,7 @@ jobs:
run: |
git config --global core.autocrlf false
git config --global core.eol lf
npm i -g npm@latest
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3
with:
# pulls all commits (needed for computing the next version)
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/renovate-jest-snap-updater.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
run: |
git config --global core.autocrlf false
git config --global core.eol lf
npm i -g npm@latest
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3
with:
ref: ${{ github.event.workflow_run.head_branch }}
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.9.0
20.12.2
226 changes: 149 additions & 77 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@commitlint/config-conventional": "17.6.1",
"@commitlint/lint": "17.6.1",
"@coveo/platform-client": "52.1.0",
"@coveo/semantic-monorepo-tools": "2.1.2",
"@coveo/semantic-monorepo-tools": "2.4.28",
"@coveord/release": "1.0.0",
"@npmcli/arborist": "6.2.8",
"@nrwl/cli": "latest",
Expand Down
Loading

0 comments on commit a32405b

Please sign in to comment.