-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency express to v4.20.0 [security] j:cdx-227 #1456
Open
renovate
wants to merge
1
commit into
master
Choose a base branch
from
renovate/npm-express-vulnerability
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
requested review from
olamothe,
y-lakhdar and
fbeaudoincoveo
and removed request for
a team
March 28, 2024 16:41
Thanks for your contribution @renovate[bot] !
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
renovate
bot
force-pushed
the
renovate/npm-express-vulnerability
branch
from
April 14, 2024 11:34
f0239cf
to
7d2021e
Compare
renovate
bot
force-pushed
the
renovate/npm-express-vulnerability
branch
from
May 4, 2024 16:51
7d2021e
to
9e620f6
Compare
renovate
bot
force-pushed
the
renovate/npm-express-vulnerability
branch
from
May 13, 2024 17:20
9e620f6
to
67a3d5d
Compare
renovate
bot
force-pushed
the
renovate/npm-express-vulnerability
branch
from
June 4, 2024 11:33
67a3d5d
to
4aa1803
Compare
renovate
bot
force-pushed
the
renovate/npm-express-vulnerability
branch
from
July 2, 2024 16:21
4aa1803
to
2ecead9
Compare
renovate
bot
force-pushed
the
renovate/npm-express-vulnerability
branch
from
July 21, 2024 14:41
2ecead9
to
a2a219d
Compare
renovate
bot
force-pushed
the
renovate/npm-express-vulnerability
branch
from
September 17, 2024 12:01
a2a219d
to
f0b918f
Compare
renovate
bot
changed the title
fix(deps): update dependency express to v4.19.2 [security] j:cdx-227
fix(deps): update dependency express to v4.20.0 [security] j:cdx-227
Sep 17, 2024
renovate-coveo
bot
force-pushed
the
renovate/npm-express-vulnerability
branch
from
December 3, 2024 13:22
f0b918f
to
0ec2904
Compare
renovate-coveo
bot
force-pushed
the
renovate/npm-express-vulnerability
branch
from
January 16, 2025 18:11
0ec2904
to
341b67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.18.2
->4.20.0
GitHub Vulnerability Alerts
CVE-2024-29041
Impact
Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.
When a user of Express performs a redirect using a user-provided URL Express performs an encode using
encodeurl
on the contents before passing it to thelocation
header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.The main method impacted is
res.location()
but this is also called from withinres.redirect()
.Patches
expressjs/express@0867302
expressjs/express@0b74695
An initial fix went out with
[email protected]
, we then patched a feature regression in4.19.1
and added improved handling for the bypass in4.19.2
.Workarounds
The fix for this involves pre-parsing the url string with either
require('node:url').parse
ornew URL
. These are steps you can take on your own before passing the user input string tores.location
orres.redirect
.References
https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location
CVE-2024-43796
Impact
In express <4.20.0, passing untrusted user input - even after sanitizing it - to
response.redirect()
may execute untrusted codePatches
this issue is patched in express 4.20.0
Workarounds
users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist
Details
successful exploitation of this vector requires the following:
Release Notes
expressjs/express (express)
v4.20.0
Compare Source
==========
depth
option to customize the depth level in the parserdepth
level for parsing URL-encoded data is now32
(previously wasInfinity
)res.redirect
\
,|
, and^
to align better with URL specoptions.maxAge
andoptions.expires
tores.clearCookie
v4.19.2
Compare Source
==========
v4.19.1
Compare Source
==========
v4.19.0
Compare Source
==========
v4.18.3
Compare Source
==========
partitioned
optionConfiguration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.