refactor(ec_plugin): add check only at the start

coveo · May 22, 2024 · 23a0d6d · 23a0d6d
1 parent cd38b20
commit 23a0d6d
Showing 1 changed file with 15 additions and 17 deletions.
diff --git a/src/plugins/ec.ts b/src/plugins/ec.ts
@@ -135,31 +135,29 @@ export class ECPlugin extends BasePlugin {
     }
 
     private addECDataToPayload(eventType: string, payload: any) {
-        const isPageView = eventType === ECPluginEventTypes.pageview;
+        if (eventType === ECPluginEventTypes.pageview) {
+            return {
+                ...this.getLocationInformation(eventType, payload),
+                ...this.getDefaultContextInformation(eventType),
+                ...payload,
+            };
+        }
+
         const ecPayload = {
             ...this.getLocationInformation(eventType, payload),
             ...this.getDefaultContextInformation(eventType),
-            ...(isPageView
-                ? {}
-                : {
-                      ...(this.action ? {action: this.action} : {}),
-                      ...(this.actionData || {}),
-                  }),
+            ...(this.action ? {action: this.action} : {}),
+            ...(this.actionData || {}),
         };
 
-        const productAndImpressionPayload = isPageView
-            ? {}
-            : {
-                  ...this.getProductPayload(),
-                  ...this.getImpressionPayload(),
-              };
+        const productPayload = this.getProductPayload();
+        const impressionPayload = this.getImpressionPayload();
 
-        if (!isPageView) {
-            this.clearData();
-        }
+        this.clearData();
 
         return {
-            ...productAndImpressionPayload,
+            ...productPayload,
+            ...impressionPayload,
             ...ecPayload,
             ...payload,
         };