adjust DNT logic (#454)

coveo · Mar 22, 2024 · 8989dc3 · 8989dc3
1 parent 17e3660
commit 8989dc3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/client/analytics.spec.ts b/src/client/analytics.spec.ts
@@ -11,10 +11,11 @@ import {IAnalyticsRequestOptions} from './analyticsRequestClient';
 import {CookieAndLocalStorage, CookieStorage, NullStorage} from '../storage';
 import HistoryStore from '../history';
 import {mockFetch} from '../../tests/fetchMock';
-import {BrowserRuntime} from './runtimeEnvironment';
+import {BrowserRuntime, NoopRuntime} from './runtimeEnvironment';
 import * as doNotTrack from '../donottrack';
 import {Cookie} from '../cookieutils';
 import {CoveoLinkParam} from '../plugins/link';
+import {NoopAnalytics} from './noopAnalytics';
 
 const aVisitorId = '123';
 jest.mock('uuid', () => ({
@@ -663,7 +664,7 @@ describe('doNotTrack', () => {
 
         let client = new CoveoAnalyticsClient({});
 
-        expect(client.runtime).toBeInstanceOf(BrowserRuntime);
+        expect(client.runtime).toBeInstanceOf(NoopRuntime);
         expect(client.runtime.storage).toBeInstanceOf(NullStorage);
     });
 

diff --git a/src/client/analytics.ts b/src/client/analytics.ts
@@ -182,9 +182,10 @@ export class CoveoAnalyticsClient implements AnalyticsClient, VisitorIdProvider
             preprocessRequest: this.options.preprocessRequest,
         };
 
-        this.runtime = this.options.runtimeEnvironment || this.initRuntime(clientsOptions);
         if (doNotTrack()) {
-            this.runtime.storage = new NullStorage();
+            this.runtime = new NoopRuntime();
+        } else {
+            this.runtime = this.options.runtimeEnvironment || this.initRuntime(clientsOptions);
         }
 
         this.addEventTypeMapping(EventType.view, {newEventType: EventType.view, addClientIdParameter: true});