Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Before the breaking change
Prior to #433, it was not fully possible to import directly from
coveo.analytics
like so:This was because the
package.json
file contained these lines:While
library.js
andlibrary.es.js
contained modules,coveoua.browser.js
did not (it globally defines "coveoua"), and the "browser" entry caused some bundlers to try and fail to use it. Additionally,library.es.js
was using expecting browser APIs whilelibrary.js
was expecting Node.js APIs.The breaking change
#433 introduced a way to import from
coveo.analytics
like so:In that process, to avoid confusion between Node CommonJS, Node ESM, browser ESM, and browser IIFE, I:
library.js
tolibrary.cjs
library.esm
library.es.js
tobrowser.mjs
Unfortunately, some of our own implementations (and likely some external) were using a workaround which involved forcefully telling their bundlers to use
library.es.js
. Since this file was renamed, those now crash.Solution
I added copies of the renamed files to their former names.
Specifically:
browser.mjs
gets copied tolibrary.es.js
library.cjs
gets copied tolibrary.js