Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(genQa): RGA ua events for insight use case created #440

Merged
merged 9 commits into from
Oct 12, 2023
Merged

feat(genQa): RGA ua events for insight use case created #440

merged 9 commits into from
Oct 12, 2023

Conversation

mmitiche
Copy link
Contributor

@mmitiche mmitiche commented Oct 10, 2023 •
edited by jira bot
Loading

SFINT-5198

The following events has been added to support RGA for the insight use case:

Custom events:

  • likeGeneratedAnswer
  • dislikeGeneratedAnswer
  • openGeneratedAnswerSource
  • generatedAnswerStreamEnd
  • generatedAnswerSourceHover
  • generatedAnswerCopyToClipboard
  • generatedAnswerHideAnswers
  • generatedAnswerShowAnswers
  • generativeQuestionFeedbackSubmit

Search events:

  • retryGeneratedAnswer
  • rephraseGeneratedAnswer

Added the ability to send generated answer metadata in all the Search UA events by adding a new function getGeneratedAnswerMetadata to the InsightClientProvider

@mmitiche mmitiche marked this pull request as ready for review October 10, 2023 19:24
@mmitiche mmitiche requested review from fvanham-coveo and a team as code owners October 10, 2023 19:24
erocheleau
erocheleau reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggest names change, did we mess up those names in the previous PR ? :(

src/insight/insightClient.ts Outdated Show resolved Hide resolved
src/insight/insightClient.ts Outdated Show resolved Hide resolved
src/insight/insightClient.ts Show resolved Hide resolved
src/insight/insightClient.ts Show resolved Hide resolved
SimonMilord
SimonMilord approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@SimonMilord SimonMilord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with etienne's suggestions and if we decide to go with that naming then tests naming should also be updated. Other than that it looks fine to me

@mmitiche
Copy link
Contributor Author

mmitiche commented Oct 11, 2023 •
edited
Loading

Some suggest names change, did we mess up those names in the previous PR ? :(

yep these were the names we used in the previous PR and the names that were mentioned in the design doc 🤷‍♂️ do we still wanna change ? x)

@mmitiche mmitiche requested a review from erocheleau October 12, 2023 13:49
@mmitiche mmitiche merged commit 30394c8 into master Oct 12, 2023
@mmitiche mmitiche deleted the SFINT-5198 branch October 12, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonMilord SimonMilord SimonMilord approved these changes

@erocheleau erocheleau erocheleau approved these changes

@fvanham-coveo fvanham-coveo Awaiting requested review from fvanham-coveo fvanham-coveo is a code owner

@jmprovencher jmprovencher Awaiting requested review from jmprovencher jmprovencher is a code owner automatically assigned from coveo/dpf-owners-1

@lbourdages lbourdages Awaiting requested review from lbourdages lbourdages is a code owner automatically assigned from coveo/dpf-owners-1

@aperron-coveo aperron-coveo Awaiting requested review from aperron-coveo aperron-coveo is a code owner automatically assigned from coveo/dpf-owners-1

@rphilippen rphilippen Awaiting requested review from rphilippen rphilippen is a code owner automatically assigned from coveo/dpf-owners-1

@fahmed-coveo fahmed-coveo Awaiting requested review from fahmed-coveo fahmed-coveo is a code owner automatically assigned from coveo/dpf-owners-1

@tsteijvers tsteijvers Awaiting requested review from tsteijvers tsteijvers is a code owner automatically assigned from coveo/dpf-owners-2

@lucylu-coveo lucylu-coveo Awaiting requested review from lucylu-coveo lucylu-coveo is a code owner automatically assigned from coveo/dpf-owners-2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmitiche @erocheleau @SimonMilord