fix: add quick window check
#447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-lakhdar
requested review from
jmprovencher,
lbourdages,
aperron-coveo,
rphilippen,
fahmed-coveo,
AdamMartineau-Coveo and
mpayne-coveo
and removed request for
a team
fvanham-coveo
approved these changes
Dec 20, 2023
rphilippen
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to generate the client ID, the
CoveoAnalyticsClientinitially tries to extract it from the browser URL by readingwindow.location.href. However, in server-side rendering (SSR) environments, such as when running the code on the server, thewindowvariable is not defined. This results in a warning message being printed to the console.Despite the window variable being undefined, the client ID is still generated randomly. However, the presence of the warning message is undesirable and can be considered an annoyance.