Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SFINT-5673): UA event logTriggerNotify added to insight client #472

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

SimonMilord
Copy link
Contributor

@SimonMilord SimonMilord commented Aug 15, 2024

SFINT-5673

Proposed changes:

The following custom event has been added to Insight Client for notify triggers in insight usecase:

  • logTriggerNotify

@SimonMilord SimonMilord requested a review from mmitiche August 15, 2024 20:28
Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an EP version of this?

@jstpierref
Copy link
Contributor

jstpierref commented Aug 16, 2024

Is there an EP version of this?

@erocheleau No! If needed, the Search API response could be used to get the info.

Copy link

@lbourdages lbourdages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks okay but I want to challenge the addition of new stuff to this library which we're trying to get rid of. Shouldn't we at least make that available in EP as Étienne suggested?

@erocheleau
Copy link
Contributor

erocheleau commented Aug 19, 2024

Overall it looks okay but I want to challenge the addition of new stuff to this library which we're trying to get rid of. Shouldn't we at least make that available in EP as Étienne suggested?

This already exists in UA, we're just adding it to our Insight version of the UA library because it was missing (we just recently added the support of QueryTriggers to the Insight Panel, or are in the process of, but it already exists for Search).

For EP we're still trying to figure out if we could perhaps rely on a server-side event instead of a client-side that's why we're not adding it to anything EP for now.

And we won't get rid of this library any time soon anyway :)

@SimonMilord SimonMilord merged commit 8e92dd5 into master Aug 19, 2024
4 checks passed
@SimonMilord SimonMilord deleted the SFINT-5673 branch August 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants