-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SFINT-5673): UA event logTriggerNotify added to insight client #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an EP version of this?
@erocheleau No! If needed, the Search API response could be used to get the info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks okay but I want to challenge the addition of new stuff to this library which we're trying to get rid of. Shouldn't we at least make that available in EP as Étienne suggested?
This already exists in UA, we're just adding it to our Insight version of the UA library because it was missing (we just recently added the support of QueryTriggers to the Insight Panel, or are in the process of, but it already exists for Search). For EP we're still trying to figure out if we could perhaps rely on a server-side event instead of a client-side that's why we're not adding it to anything EP for now. And we won't get rid of this library any time soon anyway :) |
SFINT-5673
Proposed changes:
The following custom event has been added to Insight Client for notify triggers in insight usecase: