Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve List component style #3938

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

toofff
Copy link
Member

@toofff toofff commented Oct 25, 2024

Proposed Changes

If we want to use the ordered type on the List component, then list-style-type is set to disc by default instead of decimal.

I've simply defined a root class for each HTML tag (ul and ol)

    <List type="ordered">
      <List.Item>Clone or download repository from GitHub</List.Item>
      <List.Item>Install dependencies with yarn</List.Item>
      <List.Item>To start development server run npm start command</List.Item>
      <List.Item>Run tests to make sure your changes do not break the build</List.Item>
      <List.Item>Submit a pull request once you are done</List.Item>
    </List>

https://mantine.dev/core/list/

Potential Breaking Changes

By the way, this <List type=“ordered”> is only used in the documentation website, so the impact is to delete the documentation website theme update.

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@toofff toofff requested a review from a team as a code owner October 25, 2024 01:52
@toofff toofff requested review from GermainBergeron and gdostie and removed request for a team October 25, 2024 01:52
Copy link

@GermainBergeron
Copy link
Member

Your changes cause the disk to disappear in the demo (because of the css reset probably). I'm guessing the same will happen in all apps using plasma-mantine

Before After
image image

@toofff
Copy link
Member Author

toofff commented Oct 25, 2024

Your changes cause the disk to disappear in the demo (because of the css reset probably). I'm guessing the same will happen in all apps using plasma-mantine

Strange I didn't have this locally. I'll check next week for another solution and not be fooled by the reset ;)

@toofff toofff changed the title fix: delete List component style fix: improve List component style Oct 26, 2024
@toofff
Copy link
Member Author

toofff commented Oct 26, 2024

It's fixed @GermainBergeron

image
image

@GermainBergeron GermainBergeron merged commit c51156b into master Oct 29, 2024
6 checks passed
@GermainBergeron GermainBergeron deleted the fix/link-style-component branch October 29, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants