ci(lint): fix CI workflow not linting files (#898)

* ci: run lint during CI workflow

* chore(format): run lint fix

* build(lint): stop running eslint on pre-commit

We lint on the CI anyway so no need to slowdown the commit process

* refactor(npm): remove echo in lint script

.github/workflows/ci.yml

@@ -21,6 +21,8 @@ jobs:
             - name: Check merge commit
               if: github.event_name == 'merge_group'
               uses: ./.github/actions/merge-commit
+            - name: Statical analysis
+              uses: ./.github/actions/lint
             - name: Tests
               run: npm test
             - name: Build

package.json

@@ -56,11 +56,7 @@
         "typescript-eslint": "8.4.0"
     },
     "lint-staged": {
-        "**/*.{ts,js}": [
-            "prettier --write",
-            "eslint . --fix"
-        ],
-        "**/*.{md,json,yml}": [
+        "**/*.{ts,js,md,json,yml}": [
             "prettier --write"
         ]
     },

src/resources/ApiKeys/ApiKeysInterfaces.ts

@@ -1,5 +1,6 @@
 import {GranularResource, PrivilegeModel} from '../BaseInterfaces.js';
-import {ApiKeyStatus,ApiKeyExposureReportSeverity,ApiKeyReportCreationType} from '../Enums.js';
+import {ApiKeyExposureReportSeverity, ApiKeyReportCreationType, ApiKeyStatus} from '../Enums.js';
+import {UserModel} from '../Users/UserInterfaces.js';
 
 export interface ApiKeyBaseModel extends GranularResource {
     /**
@@ -191,29 +192,27 @@ interface ImpersonationRestrictionsModel {
 
 interface ExposureReport {
     /**
-     * API Key logger id associated to the Exposure Report 
+     * API Key logger id associated to the Exposure Report
      */
-    apiKeyLoggerId: string,
+    apiKeyLoggerId: string;
     /**
-     * The severity of the exposure 
+     * The severity of the exposure
      */
-    severity: ApiKeyExposureReportSeverity,
+    severity: ApiKeyExposureReportSeverity;
     /**
-     * The reason behind the exposure report for a given API key 
+     * The reason behind the exposure report for a given API key
      */
-    reason: string,
+    reason: string;
     /**
      * The date the key should be deactivated
      */
-     deactivationDate: number,
-     /**
-      * The way the API key report has been created
-      */
-      creationType: ApiKeyReportCreationType,
-      /**
-       * Represents the user that has created the report
-       */
-      createdBy: any   
+    deactivationDate: number;
+    /**
+     * The way the API key report has been created
+     */
+    creationType: ApiKeyReportCreationType;
+    /**
+     * Represents the user that has created the report
+     */
+    createdBy: UserModel;
 }
-
-

src/resources/Enums.ts

@@ -1176,19 +1176,18 @@ export enum ApiKeyStatus {
     EXPIRED = 'EXPIRED',
     SOON_TO_BE_EXPIRED = 'SOON_TO_BE_EXPIRED',
     SOON_TO_BE_DISABLED = 'SOON_TO_BE_DISABLED',
-    DISABLED_EXPOSED = 'DISABLED_EXPOSED'
+    DISABLED_EXPOSED = 'DISABLED_EXPOSED',
 }
 
 export enum ApiKeyReportCreationType {
     MANUAL = 'MANUAL',
-    AUTOMATED = 'AUTOMATED'
+    AUTOMATED = 'AUTOMATED',
 }
 
-
 export enum ApiKeyExposureReportSeverity {
     CRITICAL = 'CRITICAL',
     HIGH = 'HIGH',
     MEDIUM = 'MEDIUM',
     LOW = 'LOW',
-    WARN = 'WARN'
-}
+    WARN = 'WARN',
+}

src/resources/License/LicenseInterfaces.ts

@@ -155,7 +155,7 @@ export interface EntitlementModel {
     /**
      * Use case of the entitlement
      */
-    useCase: string;    
+    useCase: string;
     /**
      * Limit of users for the entitlement
      */