fix(resource): fix search list fields to allow empty pipeline (#763)

coveo · Nov 2, 2023 · b9cd9d1 · b9cd9d1
1 parent 87d52da
commit b9cd9d1
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/resources/Search/Search.ts b/src/resources/Search/Search.ts
@@ -24,10 +24,14 @@ export default class Search extends Ressource {
 
     listFields(params?: SearchListFieldsParams) {
         return this.api.get<SearchListFieldsResponse>(
-            this.buildPath(`${Search.baseUrl}/fields`, {
-                ...params,
-                organizationId: params?.organizationId ?? this.api.organizationId,
-            }),
+            this.buildPath(
+                `${Search.baseUrl}/fields`,
+                {
+                    ...params,
+                    organizationId: params?.organizationId ?? this.api.organizationId,
+                },
+                {skipEmptyString: false}, // otherwise we cannot use the empty pipeline (`pipeline=`)
+            ),
         );
     }
 

diff --git a/src/resources/Search/test/Search.spec.ts b/src/resources/Search/test/Search.spec.ts
@@ -70,6 +70,14 @@ describe('Search', () => {
             );
         });
 
+        it('makes a get call to v2 search with its params to fetch the list of fields with an empty pipeline', () => {
+            search.listFields({viewAllContent: true, organizationId: 'my-org', pipeline: ''});
+            expect(api.get).toHaveBeenCalledTimes(1);
+            expect(api.get).toHaveBeenCalledWith(
+                `${Search.baseUrl}/fields?viewAllContent=true&organizationId=my-org&pipeline=`,
+            );
+        });
+
         it('adds the organizationId query param from the config if missing in the arguments', () => {
             const tempOrganizationId = api.organizationId;
             // change the value of organizationId on the mock