Merge pull request #28 from coveo/make-post-body-optional

style: add a default value to the body parameter of api.post
coveo · Oct 24, 2019 · f64531b · f64531b
2 parents 1068bba + a29fb0b
commit f64531b
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 13 deletions.
diff --git a/src/APICore.ts b/src/APICore.ts
@@ -13,7 +13,7 @@ export default class API {
 
     async post<T = {}>(
         url: string,
-        body: any,
+        body: any = {},
         args: RequestInit = {method: 'post', body: JSON.stringify(body), headers: {'Content-Type': 'application/json'}}
     ): Promise<T> {
         return await this.request<T>(url, args);

diff --git a/src/resources/Clusters/Cluster.ts b/src/resources/Clusters/Cluster.ts
@@ -35,6 +35,6 @@ export default class Cluster extends Resource {
     }
 
     synchronize(id: string) {
-        return this.api.post<{}>(`${Cluster.baseUrl}/${id}/synchronize`, {});
+        return this.api.post(`${Cluster.baseUrl}/${id}/synchronize`);
     }
 }
diff --git a/src/resources/Clusters/Nodes/ClusterNode.ts b/src/resources/Clusters/Nodes/ClusterNode.ts
@@ -15,15 +15,15 @@ export default class ClusterNode extends Resource {
     }
 
     start(clusterId: string, id: string) {
-        return this.api.post<{}>(`${ClusterNode.getBaseUrl(clusterId)}/${id}/start`, {});
+        return this.api.post(`${ClusterNode.getBaseUrl(clusterId)}/${id}/start`);
     }
 
     stop(clusterId: string, id: string) {
-        return this.api.post<{}>(`${ClusterNode.getBaseUrl(clusterId)}/${id}/stop`, {});
+        return this.api.post(`${ClusterNode.getBaseUrl(clusterId)}/${id}/stop`);
     }
 
     dump(clusterId: string, id: string) {
-        return this.api.post<{}>(`${ClusterNode.getBaseUrl(clusterId)}/${id}/dumps`, {});
+        return this.api.post(`${ClusterNode.getBaseUrl(clusterId)}/${id}/dumps`);
     }
 
     upgrade(clusterId: string, id: string, data: ClusterNodeUpgradeDataModel) {

diff --git a/src/resources/Clusters/Nodes/tests/ClusterNode.spec.ts b/src/resources/Clusters/Nodes/tests/ClusterNode.spec.ts
@@ -41,7 +41,7 @@ describe('clusterNode', () => {
             clusterNode.start(clusterId, nodeId);
 
             expect(api.post).toHaveBeenCalledTimes(1);
-            expect(api.post).toHaveBeenCalledWith(`${ClusterNode.getBaseUrl(clusterId)}/${nodeId}/start`, {});
+            expect(api.post).toHaveBeenCalledWith(`${ClusterNode.getBaseUrl(clusterId)}/${nodeId}/start`);
         });
     });
 
@@ -51,7 +51,7 @@ describe('clusterNode', () => {
             clusterNode.stop(clusterId, nodeId);
 
             expect(api.post).toHaveBeenCalledTimes(1);
-            expect(api.post).toHaveBeenCalledWith(`${ClusterNode.getBaseUrl(clusterId)}/${nodeId}/stop`, {});
+            expect(api.post).toHaveBeenCalledWith(`${ClusterNode.getBaseUrl(clusterId)}/${nodeId}/stop`);
         });
     });
 
@@ -61,7 +61,7 @@ describe('clusterNode', () => {
             clusterNode.dump(clusterId, nodeId);
 
             expect(api.post).toHaveBeenCalledTimes(1);
-            expect(api.post).toHaveBeenCalledWith(`${ClusterNode.getBaseUrl(clusterId)}/${nodeId}/dumps`, {});
+            expect(api.post).toHaveBeenCalledWith(`${ClusterNode.getBaseUrl(clusterId)}/${nodeId}/dumps`);
         });
     });
 

diff --git a/src/resources/Clusters/tests/Clusters.spec.ts b/src/resources/Clusters/tests/Clusters.spec.ts
@@ -53,7 +53,7 @@ describe('Cluster', () => {
             const clusterToSync = 'cluster-to-sync';
             cluster.synchronize(clusterToSync);
             expect(api.post).toHaveBeenCalledTimes(1);
-            expect(api.post).toHaveBeenCalledWith(`${Cluster.baseUrl}/${clusterToSync}/synchronize`, {});
+            expect(api.post).toHaveBeenCalledWith(`${Cluster.baseUrl}/${clusterToSync}/synchronize`);
         });
     });
 });
diff --git a/src/resources/Organizations/Organization.ts b/src/resources/Organizations/Organization.ts
@@ -10,7 +10,7 @@ export default class Organization extends Resource {
     }
 
     create(options: CreateOrganizationOptions) {
-        return this.api.post<OrganizationModel>(this.buildPath(Organization.baseUrl, options), {});
+        return this.api.post<OrganizationModel>(this.buildPath(Organization.baseUrl, options));
     }
 
     delete(organizationId: string) {

diff --git a/src/resources/Organizations/tests/Organizations.spec.ts b/src/resources/Organizations/tests/Organizations.spec.ts
@@ -28,7 +28,7 @@ describe('Organization', () => {
 
             organization.create({name});
             expect(api.post).toHaveBeenCalledTimes(1);
-            expect(api.post).toHaveBeenCalledWith(`${Organization.baseUrl}?name=${name}`, {});
+            expect(api.post).toHaveBeenCalledWith(`${Organization.baseUrl}?name=${name}`);
         });
     });
 

diff --git a/src/resources/SecurityCache/SecurityCache.ts b/src/resources/SecurityCache/SecurityCache.ts
@@ -36,7 +36,7 @@ export default class SecurityCache extends Ressource {
     }
 
     refreshCache() {
-        return this.api.post(`${SecurityCache.cacheUrl}/refresh`, {});
+        return this.api.post(`${SecurityCache.cacheUrl}/refresh`);
     }
 
     listProviders() {

diff --git a/src/resources/SecurityCache/tests/SecurityCache.spec.ts b/src/resources/SecurityCache/tests/SecurityCache.spec.ts
@@ -54,7 +54,7 @@ describe('securityCache', () => {
         it('should make a POST call to the securityCache refreshCache url', () => {
             securityCache.refreshCache();
             expect(api.post).toHaveBeenCalledTimes(1);
-            expect(api.post).toHaveBeenCalledWith(`${SecurityCache.cacheUrl}/refresh`, {});
+            expect(api.post).toHaveBeenCalledWith(`${SecurityCache.cacheUrl}/refresh`);
         });
     });