fix(resource): allow empty string as query param value #745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a few corrections to the
Search
API calls to/document
and/html
endpoints:getDocument
(they were missing on the swagger doc as well, see SEARCHAPI-8913)getDocument
(previously empty string query params we're removed so it was not possible)previewHTML
instead of GET. Allows to pass in the full rest parameters in the body, which unlocks all the available features of this endpoint.I also cleaned up the interfaces a bit by declaring a shared params interface and reusing it where possible. This way we avoid having to repeat the lengthy jsdocs everywhere. Still not perfect, but now we have a few repetitions less 🤷
Acceptance Criteria
Soon (see SEARCHAPI-8913)