Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ml): add missing model types for genqa #766

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

aboissinot-coveo
Copy link
Contributor

@aboissinot-coveo aboissinot-coveo commented Nov 3, 2023

Description

SEARCHAPI-9039

Add missing ML model types in Enum.ts.

  • IntentAwareProductRanking = 'intentranking'
  • RelevanceGenerativeAnswering = 'genqa'
  • SemanticSearch = 'embeddings'

I looked in the backend to confirm the values.

I also had a discussion with UI ML team about it. They told me they have a duplicated enum in the admin-ui.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

Copy link
Contributor

@lprovost-coveo lprovost-coveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving but I would rather us maintain this outside of platform-client. Also this enum also contains random stuff "useractionhistory" is not even a modeltype.

I really suggest not leveraging this enum.

@aboissinot-coveo aboissinot-coveo merged commit f5e1eaa into master Nov 3, 2023
7 checks passed
@aboissinot-coveo aboissinot-coveo deleted the SEARCHAPI-9039/ml-genqa-modeltypes branch November 3, 2023 18:25
Copy link

github-actions bot commented Nov 3, 2023

🎉 This PR is included in version 48.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants